Page MenuHomePhabricator

Installer fails when installing two extensions with the same classes
Closed, DeclinedPublic

Description

Steps to reproduce:

  1. Unpack 1.22
  2. Download an old version of SpecialInterwiki, before it was renamed[see below]
  3. run installer
  4. select extensions 'Interwiki' and SpecialInterwiki

The SpecialInterwiki -> Interwiki rename happened 2010-04-17:
https://git.wikimedia.org/commit/mediawiki%2Fextensions%2FInterwiki/3a46e6374ee5426e5dce60280e7c71522a4b31b5
the version before that is needed; Fedora Core's last packaged version of this extension is '0.11.20080913svn'

Expected result:
The installer detects there are two extensions with the same class (SpecialInterwiki), and notify the person running the installer.

Actual results:
The installer offers both, and (if selected) they crash the installer.


Version: 1.22.0
Severity: minor
See Also:
https://bugzilla.redhat.com/show_bug.cgi?id=1039226

Details

Reference
bz58313

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 2:41 AM
bzimport set Reference to bz58313.
bzimport added a subscriber: Unknown Object (MLST).
Legoktm subscribed.

I don't think there's much the installer can do here, checking every extension against every other extension for any potential duplicated classes, functions, constants seems a bit excessive. Maybe extension.json could use a "breaks"/"conflicts" option or something?