| • bzimport | |
| Dec 11 2013, 1:34 PM |
| F12804: Wiktionary48.ico | |
| Nov 22 2014, 2:42 AM |
| F12803: Wiktionary16.ico | |
| Nov 22 2014, 2:42 AM |
Author: adityagulati
Description:
32x32 size
Create a favicon including 16x16, 32x32, and 48x48 versions of https://upload.wikimedia.org/wikipedia/commons/3/35/Simple_Wiktionary_logo.png. Substitute wiktionary/en.ico at operations/mediawiki-config/docroot/bits/favicon with the new version.
Version: wmf-deployment
Severity: enhancement
URL: http://www.google-melange.com/gci/task/view/google/gci2013/5777530279690240
Attached:
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | None | T47036 Update favicons to provide high res variant | |||
| Resolved | Sn1per | T60326 Update favicon wiktionary/en.ico |
Hello Aditya, please follow the instructions of the Google Code-in task.
What we are looking for is one single favicon with three layers contributed as a Gerrit changeset.
As an example, check Bug 58144 and its related https://gerrit.wikimedia.org/r/100133
You have links with information about Git and Gerrit at https://www.mediawiki.org/wiki/Google_Code-In
Thank you!
Hi Adit,
(In reply to bug 58523 comment #2)
Since I have the .ico made, should I just make a pull request to the main
public repo so that it will be uploaded to the main project?
You must submit a patch via Gerrit, specifying in the commit message the bug report you are solving. See for example bug 58122 and its related https://gerrit.wikimedia.org/r/#/c/99756/
A pull request in GitHub is not bad for a first try but we are expecting the patch to follow the Gerrit review process that we apply to all our contributions. If you are not familiar with Gerrit you can check the tutorial and other interesting links at
https://www.mediawiki.org/wiki/Google_Code-In#Suggested_reading
We hope to see the link to your patch for review soon!
Change 102386 had a related patch set uploaded by Aquifacae:
Changed wiktionary/en.ico favicon to proper image and resolutions
Change 102386 abandoned by Aquifacae:
Changed wiktionary/en.ico favicon to proper image and resolutions
Reason:
Decided not to use this image for favicon
Change 102554 had a related patch set uploaded by Aquifacae:
Added new 48x48 resolution to original favicon
Change 102554 abandoned by Aquifacae:
Added new 48x48 resolution to wiktionary/en favicon
Change 102602 had a related patch set uploaded by Aquifacae:
Made proper larger favicon wiktionary/en.ico favicon.
Change 103183 had a related patch set uploaded by Sn1per:
Fix en.wiktionary favicon for GCI 2013