Page MenuHomePhabricator
Create Task
Maniphest T60333

[Regression] PHP fatal error in /includes/revisiondelete/RevisionDelete.php line 672: Cannot access private property ArchivedFile::$user
Closed, ResolvedPublic
Actions

Description

PHP fatal error in /usr/local/apache/common-local/php-1.23wmf6/includes/revisiondelete/RevisionDelete.php line 672:
Cannot access private property ArchivedFile::$user

Reported by an Oversighted while trying to undo an oversight action.

Version: 1.23.0
Severity: normal

Details

Reference
bz58333

Event Timeline

• bzimport raised the priority of this task from to High.Nov 22 2014, 2:43 AM
• bzimport added a project: MediaWiki-Revision-deletion.
• bzimport set Reference to bz58333.
• bzimport added a subscriber: Unknown Object (MLST).
Raymond created this task.Dec 11 2013, 4:28 PM
gerritbot added a comment.Dec 11 2013, 7:19 PM

Change 100825 had a related patch set uploaded by Aaron Schulz:
Avoid calling protected File field

https://gerrit.wikimedia.org/r/100825

gerritbot added a comment.Dec 12 2013, 6:51 PM

Change 100825 merged by Brian Wolff:
Avoid calling protected File field

https://gerrit.wikimedia.org/r/100825

gerritbot added a comment.Dec 17 2013, 5:31 PM

Change 102176 had a related patch set uploaded by Legoktm:
Avoid calling protected File field

https://gerrit.wikimedia.org/r/102176

gerritbot added a comment.Dec 17 2013, 5:32 PM

Change 102177 had a related patch set uploaded by Legoktm:
Avoid calling protected File field

https://gerrit.wikimedia.org/r/102177

Legoktm added a comment.Dec 17 2013, 5:36 PM

Per quick discussion with Greg and Tomasz in -operations, this is getting backported to 1.23wmf6 and 1.23wmf7.

gerritbot added a comment.Dec 17 2013, 5:48 PM

Change 102177 merged by jenkins-bot:
Avoid calling protected File field

https://gerrit.wikimedia.org/r/102177

gerritbot added a comment.Dec 17 2013, 5:50 PM

Change 102176 merged by jenkins-bot:
Avoid calling protected File field

https://gerrit.wikimedia.org/r/102176

tomasz added a comment.Dec 17 2013, 10:03 PM

This is now fixed, backported, and deployed onto all Wikimedia projects.

Thanks to Aaron for the fix, and to Legoktm for backporting.

\o/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL