Page MenuHomePhabricator

Schema validation issues on mediawiki.org
Closed, ResolvedPublic

Description

On MediaWiki.org if I open the echo notification overlay I get a flood of errors:

Validation error against schema EchoInteraction: Value "mobile-overlay" for property: context not in enum ["flyout","archive"]


Version: unspecified
Severity: normal

Details

Reference
bz58336

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:43 AM
bzimport added a project: Notifications.
bzimport set Reference to bz58336.
bzimport added a subscriber: Unknown Object (MLST).

bingle-admin wrote:

Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1499

bsitu wrote:

This is not really an Echo problem. In site configuration file, the Echo interaction schema is still pointing to revision: 5539940, which doesn't have 'mobile-overlay' defined. The fix is easy, just update the schema to latest in the file and deploy the change.

Whenever something is added to the schema and the code needs to use the new definition, the schema id needs to be updated in site configuration file.

I thought the revision was set in Echo extension but it sounds from what you are saying it is in a config file somewhere?

This doesn't seem like the best idea - MobileFrontend used to do that and it made updating schemas tricky. I'd really advise doing the same in Echo to avoid these types of confusion and also allow you to run 2 different revisions of schemas on 2 different codebases more easily.

Here's how we do it:
https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/includes/MobileFrontend.hooks.php#L706

Also effecting enwiki now meaning you are not logging events there.

Change 103611 had a related patch set uploaded by Kaldari:
Updating schema ID for EchoInteraction

https://gerrit.wikimedia.org/r/103611

Change 103611 merged by jenkins-bot:
Updating schema ID for EchoInteraction

https://gerrit.wikimedia.org/r/103611

Patch was merged a while ago - is there more work left to do here (if yes: please reset the bug report status to NEW or ASSIGNED), or can you close this ticket as RESOLVED FIXED?