Page MenuHomePhabricator

Graph of pending reviews in Gerrit shows wrong data
Closed, DeclinedPublic

Description

The "pending" graph at http://korma.wmflabs.org/browser/scr.html shows a growth of pending Gerrit reviews that reaches a maximum of 38360 in February 2013, then drops to 886 in March.

The data must be reviewed. Anything above, say, 2000 pending reviews seems totally unrealistic, leave alone anything on the range of 30k open reviews.


Version: unspecified
Severity: normal

Details

Reference
bz58349

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 2:44 AM
bzimport set Reference to bz58349.

Using ssh interface we have wrong data about the changes in the review process. For example:

https://gerrit.wikimedia.org/r/#/c/51369/

From the web interface the +2 change is on Feb 28, 2013.
But using the ssh interface:

acs@lenovix:~$ ssh -p 29418 gerrit.wikimedia.org gerrit query --format=JSON 51369 --all-approvals
...
"type":"Code-Review",

"description":"Code-Review",
"value":"2",
"grantedOn":1364577872,

...
acs@lenovix:~$ LANG= date -ud @1364577872
Fri Mar 29 17:24:32 UTC 2013

This problem is fixed after 2013-04. This is why all graphs that needs changes data should start from 2013-04.

Chad, are you aware of his problem of wrong Gerrit data provided via ssh, and do you see any possibility to fix it?

Otherwise we can solve this as WONTFIX and simply start the Gerrit review metrics from 2013-04 onward, where this problem doesn't exist.

(In reply to Quim Gil from comment #2)

Otherwise we can solve this as WONTFIX and simply start the Gerrit review
metrics from 2013-04 onward, where this problem doesn't exist.

This.