Page MenuHomePhabricator
Create Task
Maniphest T60404

VisualEditor: The toolbar design inside the MediaSettings and Reference does not match with the new toolbar design on main CE
Closed, ResolvedPublic
Actions

Description

Screenshot inside reference

We have changed the toolbar design to have all the formatting under one button A (underlined) and all other options to add elements under Insert option.

But if you open up the Media Settings or a Reference the toolbar that appears there does not conform with the new design.
It will better to have a consistent design everywhere the toolbar is used.

See the screemshots attached.

Version: unspecified
Severity: minor

Attached:

Screen_Shot_2013-12-12_at_10.45.43_AM.png (285×1 px, 47 KB)

Details

Reference
bz58404

Event Timeline

• bzimport raised the priority of this task from to High.Nov 22 2014, 2:17 AM
• bzimport added projects: VE-deploy-2013-12-12, VisualEditor-EditingTools.
• bzimport set Reference to bz58404.
Ryasmeen created this task.Dec 12 2013, 6:49 PM
Ryasmeen added a comment.Dec 12 2013, 6:51 PM

Created attachment 14073
toolbar inside media settings

Attached:

Screen_Shot_2013-12-12_at_10.45.16_AM.png (294×1 px, 57 KB)

gerritbot added a comment.Dec 12 2013, 7:22 PM

Change 101039 had a related patch set uploaded by Jforrester:
Use the same new toolbar for media and reference dialogs

https://gerrit.wikimedia.org/r/101039

gerritbot added a comment.Dec 12 2013, 7:31 PM

Change 101047 had a related patch set uploaded by Jforrester:
Use the same new toolbar for media and reference dialogs

https://gerrit.wikimedia.org/r/101047

gerritbot added a comment.Dec 12 2013, 7:32 PM

Change 101039 merged by jenkins-bot:
Use the same new toolbar for media and reference dialogs

https://gerrit.wikimedia.org/r/101039

gerritbot added a comment.Dec 12 2013, 11:16 PM

Change 101047 merged by Catrope:
Use the same new toolbar for media and reference dialogs

https://gerrit.wikimedia.org/r/101047

Jdforrester-WMF added a comment.Dec 12 2013, 11:20 PM

Now being deployed on wmf7.

Ryasmeen added a comment.Dec 13 2013, 8:19 PM

verified the fix in test2:https://test2.wikipedia.org/w/index.php?title=User:RYasmeen_(WMF)&veaction=edit

Jdforrester-WMF added a project: VisualEditor.Dec 3 2014, 2:12 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL