Page MenuHomePhabricator
Create Task
Maniphest T60414

SpecialTranslatorSignup::getOtherWikis() returns closed, private and fishbowl wikis
Closed, ResolvedPublic
Actions

Description

getOtherWikis() seems to be intended to return all.dblist minus the closed, private and fishbowl dblist files. In the current implementation however it seems to always return the entire all.dblist due at least in part to some small programming errors.

  • $wgDBname is used inside the loop instead of $dbname
  • SiteMatrix::isPrivate() and SiteMatrix::isFishbowl() expect to be called with a database name rather than a site & language pair

Version: unspecified
Severity: normal

Details

Reference
bz58414

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:18 AM
• bzimport added a project: TranslationNotifications.
• bzimport set Reference to bz58414.
• bzimport added a subscriber: Unknown Object (MLST).
bd808 created this task.Dec 12 2013, 10:22 PM
gerritbot added a comment.Dec 12 2013, 10:28 PM

Change 101128 had a related patch set uploaded by BryanDavis:
Fix SpecialTranslatorSignup::getOtherWikis()

https://gerrit.wikimedia.org/r/101128

gerritbot added a comment.Jan 7 2014, 4:27 PM

Change 101128 merged by jenkins-bot:
Fix SpecialTranslatorSignup::getOtherWikis()

https://gerrit.wikimedia.org/r/101128

Amire80 added a comment.Mar 31 2014, 11:43 AM

Thanks for the fix.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL