Wrong smart keyword on Wikidata
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Fomafix
	Dec 13 2013, 10:03 PM

Description

Firefox generates smart keywords from a search bar: https://support.mozilla.org/en-US/kb/how-search-from-address-bar

On Wikidata it generates the wrong bookmark
https://www.wikidata.org/w/index.php?=%s&search=&title=Special%3ASearch

Expected bookmark is
https://www.wikidata.org/w/index.php?search=%s&title=Special%3ASearch

The reason is in the JavaScript code. The original HTML from server is

		<input name="search" placeholder="Search" title="Search Wikidata [f]" accesskey="f" id="searchInput" />
		<button type="submit" name="button" title="Search the pages for this text" id="searchButton">
			<img src="//bits.wikimedia.org/static-1.23wmf6/skins/vector/images/search-ltr.png?303-4" alt="Search" width="12" height="13" />
		</button>
		<input type='hidden' name="title" value="Special:Search"/>

</div>
</form>

JavaScript converts this the following HTML code with a duplicate <input> element:

		<input id="searchInput" accesskey="f" title="Search Wikidata [alt-shift-f]" placeholder="Search" class="ui-autocomplete-input ui-suggester-input ui-entityselector-input" autocomplete="off" role="textbox" aria-autocomplete="list" aria-haspopup="true" tabindex="1">
		<input type="hidden" name="search" value="">
		<button id="searchButton" title="Search the pages for this text" name="button" type="submit">
			<img width="12" height="13" alt="Search" src="//bits.wikimedia.org/static-1.23wmf6/skins/vector/images/search-ltr.png?303-4">
		</button>
		<input type="hidden" value="Special:Search" name="title">

</div>
</form>

The JavaScript code on www.mediawiki.org works and converts the HTML to

		<input id="searchInput" accesskey="f" title="Search MediaWiki [alt-shift-f]" placeholder="Search" name="search" tabindex="1" autocomplete="off">
		<button id="searchButton" title="Search the pages for this text" name="button" type="submit">
			<img width="12" height="13" alt="Search" src="//bits.wikimedia.org/static-1.23wmf7/skins/vector/images/search-ltr.png?303-4">
		</button>
		<input type="hidden" value="Special:Search" name="title">

</div>
</form>

Version: master
Severity: minor
Whiteboard: u=dev c=frontend p=0

Details

Reference: bz58467

Related Objects

Mentioned In: T276474: '.event.query' should be string

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 2:21 AM

• bzimport added projects: MediaWiki-extensions-WikibaseClient, JavaScript, patch-welcome.

• bzimport set Reference to bz58467.

• bzimport added a subscriber: Unknown Object (MLST).

Fomafix created this task.Dec 13 2013, 10:03 PM

Oh, wow. This is clearly a bug in Firefox. You know that, right? Not that we shouldn't work around it. We should.

I had two ideas:

1.) Switch the order of the two <input>, the named hidden <input> first, our unnamed <input> after.
Result: .../index.php?search=&=%s&title=Spezial%3ASuche

2.) Give both <input> the same name="search".
Result: .../index.php?search=%s&search=&title=Spezial%3ASuche
Dang, this overrides the user's input with an empty string.

3.) Do both. Works.

Change 174387 had a related patch set uploaded by Thiemo Mättig (WMDE):
Fix entitysearch to support Firefox smart keyword

https://gerrit.wikimedia.org/r/174387

There is not bug in Firefox. It converts the <input>s in the form to a query string like in HTML. The reason are the two <input>s. Why are there two <input>s? They seams to be redundant. The implementation on mediawiki.org works with one <input>.

Turning an unnamed input into index.php?=%s is clearly a bug in Firefox. I'm not aware of a server side language that supports unnames GET variables. In PHP that would be $_GET['']. I just tried that just to be sure and no, PHP doesn't support this.

Again, this doesn't mean we should not work around this issue. See my patch.

Ok, an <input> without name is ignored in the normal transformation from a <form> to a query string. Here has the <input> for which the smart keyword is requested no name. When this <input> get omitted the query string for the smart keyword would have no %s. ?=%s is a comprehensible query string for the smart keyword on a <input> without a name.

Generating two <input>s with the same name is a bad solution for this problem. The right solution is to combine the two <input>s to one <input>.

Lydia_Pintscher added a project: Wikidata.Dec 1 2014, 2:53 PM

Lydia_Pintscher removed a subscriber: Unknown Object (MLST).