Page MenuHomePhabricator

Sysops cannot edit sysop protected items unless they are members of certain other user groups
Closed, ResolvedPublic

Description

A recent weird bug cropped up on Wikidata where *some* sysops are unable to edit sysop protected pages. Two currently protected pages are; https://www.wikidata.org/wiki/Q5268366 and https://www.wikidata.org/wiki/Q16503.

After speaking with Addshore, it turns out we both have this weird issue. His solution tested out was granting both of us confirmed user flags (log: [1]) which apparently made us able to edit protected items.

This seems like an awfully weird bug which really should be looked into in more depth. Also this is a Wikibase issue as all other non wikibase pages are editable without the confirmed user flag.

[1] https://www.wikidata.org/w/index.php?title=Special%3ALog&type=rights&user=Addshore&page=&timestamp=20131213235000&limit=2


Version: unspecified
Severity: normal
Whiteboard: u=dev c=backend p=0

Details

Reference
bz58474

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 2:22 AM
bzimport set Reference to bz58474.
bzimport added a subscriber: Unknown Object (MLST).

hahc21 wrote:

I had the same issue, though it did not get solved by adding the confirmed group when I first tried. (I fullyprotected an item, then tried to edit, which didn't work. Then added the confirmed group and tried to edit, didn't work either. Maybe I forgot to clear cache).

Cheers.

hahc21 wrote:

Oh well nevermind. I tried again and it worked.

Cheers.

I see that the edit and add links are greyed out too, and they say the page is protected. However when I used the labelLister to edit a description it worked, https://www.wikidata.org/w/index.php?title=Q5268366&diff=prev&oldid=103258789

This is still happening. Just tested now.

I have done some testing on testwikidatawiki with the following results:

Account User:Vogone@testwikidatawiki (member of groups: Administrators, Autoconfirmed users, Bureaucrats, Users):

With bureaucrat rights assigned, the bug wasn't reproducable. The other groups (Administrators, Autoconfirmed users, Users) didn't seem to affect the bug at all.

Account User:VogoTest@testwikidatawiki (member of groups: Administrators, OAuth administrators, Users):

With oauthadmin rights (used as a random user group with meaningless user rights here) assigned, the bug wasn't reproducable. The other groups (Administrators, Users) didn't seem to affect the bug at all.

Account User:VogoTest2@testwikidatawiki (member of groups: Administrators, IP block exemptions, Users):

With ip-block-exempt rights assigned, the bug wasn't reproducable. The other groups (Administrators, Users) didn't seem to affect the bug at all. The same was tested with rollback/propertycreator/confirmed (bug wasn't reproducable) and translationadmin/flooder (bug was reproducable) instead of ip-block-exempt rights assigned.

There is one more thing I found out.

Apparently non-admins who are in global groups (tested global groups: Global_sysops, stewards) but /no/ local sysops aren't affected by this bug either. However, global sysops who have the local sysop flag assigned at the same time are affected.

(https://meta.wikimedia.org/w/index.php?title=Special%3ALog&type=&user=DerHexer&page=User%3AVogone%40testwikidatawiki&year=&month=-1&tagfilter=&hide_review_log=1&hide_thanks_log=1)

Vogone asked me to test something on my Wikibase repo and the results were... interesting to say the least. I have four users.

User A is an administrator and bureaucrat. This user can edit a sysop protected item with no issue.

User B is sysop only. This user can not edit a sysop protected item.

User C is an administrator and 'adminguy' (my dupe sysop group), they can edit the sysop protected item.

User D is an 'adminguy' only. This user *can* edit a sysop protected item.

Therefore, I am making a weird conclusion that the only thing stopping sysops editing a sysop protected item is because they are a sysop (with the group name 'sysop' specifically). Global sysops on Wikimedia can edit sysop protected items because they are either a) not a local admin or b) not a 'sysop' only.

Change 122124 had a related patch set uploaded by Hoo man:
Fix edit restriction handling

https://gerrit.wikimedia.org/r/122124

Change 122124 merged by jenkins-bot:
Fix edit restriction handling

https://gerrit.wikimedia.org/r/122124

Change 124310 had a related patch set uploaded by Aude:
Fix edit restriction handling

https://gerrit.wikimedia.org/r/124310

Change has been approved and will be backported

Change 124310 merged by jenkins-bot:
Fix edit restriction handling

https://gerrit.wikimedia.org/r/124310