thewub.wiki wrote:

See also mingle card #1027
https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1027

Now that we moved the thank you pages to thankyou.wikipedia.org, this should be possible at least for banners. Here's the plan:

When someone clicks through a banner to donate, before going to payments they get a cookie fundraising_returnTo with the URL of the page they were on. This is for domain .wikipedia.org and has a short life (5 minutes). Example banner which sets this cookie

mw.loader.using( 'mediawiki.cookie' ).then( function () {
    mw.cookie.set(
        'fundraising_returnTo',
        window.location.origin + window.location.pathname,
        { expires: 300, prefix: '', domain: '.wikipedia.org', secure: true }
    );
});

Then the Thank You page checks to see if a user has that cookie, and if so it shows a "Return to Wikipedia" link with the correct URL. It then clears the cookie. Example TY page (this will always show the link, just for demonstration purposes)

mw.loader.using( 'mediawiki.cookie' ).then( function () {
    var returnToUrl = mw.cookie.get( 'fundraising_returnTo', '' );
    if ( returnToUrl ) {
        $( '.ty-return a' ).attr( 'href', returnToUrl );
        $( '.ty-return' ).show();
        mw.cookie.set( 'fundraising_returnTo', null, { prefix: '', domain: '.wikipedia.org' } );
    }
});

@DStrine Can someone from fr-tech take a look at this approach and confirm it seems sensible?

Wow this is ancient. I've moved it to triage to discuss on Monday.

Hi @Pcoombe! Overall this seems quite sane! (Caveat: I haven't tested it or anything.) Initially I was concerned that cookies are a performance draw, since they're sent back and forth on every HTTP request, however, with the short expiry time, that seems fine. Normally we would actually prefer LocalStorage to cookies, but I think you can't share that among subdomains easily. Also, LocalStorage has no build-in expiry mechanism (important for cases where the user doesn't make it to the TY page). So it seems cookies would indeed be the way to go.

Do we need to maybe double-check with Legal or anyone else about creating this cookie?

Thanks!!

Thanks @AndyRussG! Yes I did look at LocalStorage first, but you're right that it can't work across subdomains, so I think it has to be a cookie.

I've emailed Stephen in Legal to get his input.

Legal signing off. Thanks!

This is super cool, thanks @Pcoombe