Page MenuHomePhabricator

Unsightly blue highlight when toggling open sections
Closed, ResolvedPublic

Description

Blue highlight

Recent accessibility changes to code mean that sections now get highlighted when toggled open. I'm not sure whether we want this or not as it looks very strange (see attachment)


Version: unspecified
Severity: normal

Attached:

Screen_Shot_2013-12-16_at_10.36.40_AM.png (285×559 px, 37 KB)

Details

Reference
bz58540

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:26 AM
bzimport set Reference to bz58540.
bzimport added a subscriber: Unknown Object (MLST).

bingle-admin wrote:

Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1513

I don't really care what you do with this on mobile (probably doesn't matter much over there). But please don't disable the outline on desktop platforms, as it's the only way to see what currently has focus (important if using keyboard navigation).

Change 103750 had a related patch set uploaded by JGonera:
Remove focus outlines on touch devices

https://gerrit.wikimedia.org/r/103750

This patch didn't fix the bug - need to use the following for that:

-webkit-tap-highlight-color: rgba(255, 255, 255, 0);
tap-highlight-color: rgba(255, 255, 255, 0);

jgonera wrote:

Either the bug has a wrong screenshot attached to it, or the patch did fix the bug. tap-highlight-color changes the background when something is tapped, not the outline shown in the screenshot.

I've created a new bug to make you happier.

  • This bug has been marked as a duplicate of bug 58978 ***