Page MenuHomePhabricator
Create Task
Maniphest T60610

Score constructs an FSBackend in a deprecated fashion
Closed, ResolvedPublic
Actions

Description

Deprecated: Use of FileBackend::construct called without "wikiID". was deprecated in MediaWiki 1.23. [Called from FileBackendStore::construct in /var/www/w/git/includes/filebackend/FileBackendStore.php at line 68] in /var/www/w/git/includes/debug/Debug.php on line 301

Deprecated: Use of FileBackend::construct called with non-object "lockManager". was deprecated in MediaWiki 1.23. [Called from FileBackendStore::construct in /var/www/w/git/includes/filebackend/FileBackendStore.php at line 68] in /var/www/w/git/includes/debug/Debug.php on line 301

Possible gci bug. Needs to modify Score::getBackend(), so that the default config doesn't create a new FSFileBackend object without specifying wikiID and a lockManager. The appropriate values are probably just wfWikiId() and new NullLockManager( array() ) respectively.

Version: unspecified
Severity: minor
URL: http://www.google-melange.com/gci/task/view/google/gci2013/6349072852058112

Details

Reference
bz58610

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 2:30 AM
• bzimport added projects: MediaWiki-extensions-Score, good first task.
• bzimport set Reference to bz58610.
• bzimport added a subscriber: Unknown Object (MLST).
Bawolff created this task.Dec 18 2013, 12:28 AM
aaron added a comment.Dec 18 2013, 12:31 AM

(In reply to comment #0)

Possible gci bug. Needs to modify Score::getBackend(), so that the default
config doesn't create a new FSFileBackend object without specifying wikiID
and
a lockManager. The appropriate values are probably just wfWikiId() and new
NullLockManager( array() ) respectively.

Yep

Qgil added a comment.Dec 18 2013, 4:48 PM

(In reply to comment #0)

Possible gci bug.

Created. Note that we rely on you for support and review. Thank you!

Bawolff added a comment.Dec 18 2013, 7:02 PM

(In reply to comment #2)

(In reply to comment #0)

Possible gci bug.

Created. Note that we rely on you for support and review. Thank you!

For any GCI students reading this, you also have to set $wgDevelopmentWarnings = true; in your LocalSettings.php to see the warnings mentioned above.

gerritbot added a comment.Dec 21 2013, 5:43 AM

Change 103088 had a related patch set uploaded by Theopolisme:
Fix depreciation warnings in FileBackend construction

https://gerrit.wikimedia.org/r/103088

gerritbot added a comment.Dec 21 2013, 6:02 AM

Change 103088 merged by jenkins-bot:
Fix depreciation warnings in FileBackend construction

https://gerrit.wikimedia.org/r/103088

• Gilles added a project: Multimedia.Dec 4 2014, 10:53 AM
• Gilles moved this task from Untriaged to Done on the Multimedia board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL