Page MenuHomePhabricator
Create Task
Maniphest T60618

[scap] Touch InitialiseSettings.php if syncing
Closed, ResolvedPublic
Actions

Description

When doing sync-file InitialiseSettings.php, sync-dir wmf-config, or even scap, we should probably touch InitialiseSettings.php to cause a config recache...

Certainly at least the specific sync-file with it as a target

We've had bugs from this before, and bug 58612

Version: unspecified
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=58612

Details

Reference
bz58618

Related Objects

Event Timeline

• bzimport raised the priority of this task from to High.Nov 22 2014, 2:31 AM
• bzimport added a project: Deployments.
• bzimport set Reference to bz58618.
Reedy created this task.Dec 18 2013, 2:07 AM
greg added a comment.May 22 2014, 8:14 PM

Yep.

gerritbot added a comment.May 28 2014, 12:01 AM

Change 135724 had a related patch set uploaded by BryanDavis:
Invalidate local configuration cache on sync

https://gerrit.wikimedia.org/r/135724

gerritbot added a comment.May 28 2014, 4:50 PM

Change 135724 merged by jenkins-bot:
Invalidate local configuration cache on sync

https://gerrit.wikimedia.org/r/135724

bd808 added a comment.May 28 2014, 8:05 PM

Verified that timestamp of /usr/local/apache/common-local/wmf-config/InitialiseSettings.php updated following a scap.

greg moved this task from To Triage to Done on the Deployments board.Jan 8 2015, 5:39 PM
bd808 mentioned this in T127167: HHVM doesn't always properly notice files changed via scap's sync-dir, touch needed.Feb 17 2016, 3:51 PM
greg mentioned this in T131809: Create sync-config subcommand.Apr 4 2016, 9:11 PM
thcipriani mentioned this in T217830: Changing dblist files requires mtime touch of InitialiseSettings.php.Mar 7 2019, 3:13 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL