Page MenuHomePhabricator

Flow: Merge RecentChanges & Contributions' formatters extend from 1 same base class
Closed, ResolvedPublic

Description

Title is self-explanatory. They share a lot of functionality.

Implementation ideas:
Contributions was the last one to be build, so re-used a lot from RecentChanges. Doing so, Most methods were updated to receive/return different parameters.
We should probably be able to re-use most utility methods as they are in Contributions/Formatter (and get rid of the of RC), with only some minor changes to RC's main format function.


Version: unspecified
Severity: normal

Details

Reference
bz58645

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:33 AM
bzimport set Reference to bz58645.
bzimport added a subscriber: Unknown Object (MLST).

bingle-admin wrote:

The WMF core features team tracks this bug on Mingle card https://mingle.corp.wikimedia.org/projects/flow/cards/630, but people from the community are welcome to contribute here and in Gerrit.

Change 102674 had a related patch set uploaded by Matthias Mullie:
(bug 58645) Merge RecentChanges & Contributions' formatters extend from 1 same base class

https://gerrit.wikimedia.org/r/102674

Change 102674 merged by jenkins-bot:
(bug 58645) Merge RecentChanges & Contributions' formatters extend from 1 same base class

https://gerrit.wikimedia.org/r/102674

Patch got merged, so closing the bug. Please reopen if that's not the case.