New line at end of document sometimes merged into previous line on paste
Open, MediumPublic
Actions

Assigned To

None

Authored By

	Esanders
	Dec 19 2013, 4:46 PM

Description

Copied from bug 58347:

1.Create a page "A" with three links in three consecutive lines.
2.Create another page "B" where you will copy these links to.
3.Copy the first and second link to "B"
4.Save it.
5.Reopen the editor.
6.Now copy the third link and paste it to the third line of "B"
7.Save it.

Observed Result:
The second and the third link in page B is getting merged.

Example Pages:

A:http://en.wikipedia.beta.wmflabs.org/wiki/19th_december_source?veaction=edit
B:http://en.wikipedia.beta.wmflabs.org/wiki/19th_destination

Version: unspecified
Severity: normal

Details

Reference: bz58695

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:36 AM

• bzimport added a project: VisualEditor.

• bzimport set Reference to bz58695.

Esanders created this task.Dec 19 2013, 4:46 PM

Can you provide a sample of the relevant HTML your are producing in VE?

The original issue described in this bug is not occurring anymore but a similar issue is found not sure if they are related or not.If not, I will file a separate issue:

1.Create a page "A" with a template Cite Web
2.Create another page "B" where you will copy the template.
3.Add some text or any other element like math function/Link to Page "B"
4.Copy the CiteWeb template created in page A and paste it into the next line of B

Observed Result:
The template gets merged with the previous element/line.

Test Environment: http://en.wikipedia.beta.wmflabs.org/
Browser: Chrome Version 26.0.1410.65
OS: MAC OS X 10. 8. 5
Page:http://en.wikipedia.beta.wmflabs.org/wiki/Copy-paste6th

See the screenshot attached.

Created attachment 14240
Screenshot of template getting merged with the previous line

Attached:

Screen_Shot_2014-01-06_at_2.41.28_PM.png (520×1 px, 124 KB)

HTML dump:

Request URL:http://en.wikipedia.beta.wmflabs.org/w/api.php
Request Method:POST
Status Code:200 OK
Request Headersview source
Accept:application/json, text/javascript, */*; q=0.01
Accept-Charset:ISO-8859-1,utf-8;q=0.7,*;q=0.3
Accept-Encoding:gzip,deflate,sdch
Accept-Language:en-US,en;q=0.8
Connection:keep-alive
Content-Length:10758
Content-Type:application/x-www-form-urlencoded; charset=UTF-8
Cookie:uls-previous-languages=%5B%22en%22%5D; mediaWiki.user.sessionId=IWxgkz08OFNZxaGwaIxUNKilap37xFbY; mediaWiki.user.bucket%3Aext.articleFeedbackv5%4011-tracking=11%3Aignore; mediaWiki.user.bucket%3Aext.articleFeedbackv5%406-form=6%3A6; mediaWiki.user.bucket%3Aext.articleFeedbackv5%405-links=5%3AX; centralnotice_bucket=1-4.2; enwikiLoggedOut=1389029323; centralauth_LoggedOut=1389029332; enwikiUserID=1348; enwikiUserName=RYasmeen+%28WMF%29; enwikiSession=568d9870c44e9934b5912175d6faaea9; centralauth_User=RYasmeen+%28WMF%29; centralauth_Session=0d74cc0544d444b6ba6b684092f01228; edittoolscharsubset=0; ve-beta-welcome-dialog=1
Host:en.wikipedia.beta.wmflabs.org
Origin:http://en.wikipedia.beta.wmflabs.org
Referer:http://en.wikipedia.beta.wmflabs.org/wiki/Copy-paste6th?veaction=edit
User-Agent:Mozilla/5.0 (Macintosh; Intel Mac OS X 10_8_5) AppleWebKit/537.31 (KHTML, like Gecko) Chrome/26.0.1410.65 Safari/537.31
X-Requested-With:XMLHttpRequest
Form Dataview sourceview URL encoded
action:visualeditor
paction:serializeforcache
html:<!doctype html><html prefix="dc: http://purl.org/dc/terms/ mw: http://mediawiki.org/rdf/" about="http://en.wikipedia.beta.wmflabs.org/wiki/Special:Redirect/revision/73736"><head prefix="mwr: http://en.wikipedia.beta.wmflabs.org/wiki/Special:Redirect/"><meta property="mw:articleNamespace" content="0"><link rel="dc:replaces" resource="mwr:revision/73705"><meta property="dc:modified" content="2014-01-07T01:05:54.000Z"><meta about="mwr:user/1348" property="dc:title" content="RYasmeen (WMF)"><link rel="dc:contributor" resource="mwr:user/1348"><meta property="mw:revisionSHA1" content="a473161a3483e47f6d590fd9f039238f9303b459"><meta property="dc:description" content=""><meta property="mw:parsoidVersion" content="0"><link rel="dc:isVersionOf" href="en.wikipedia.beta.wmflabs.org/wiki/Copy-paste6th"><title>Copy-paste6th</title><base href="en.wikipedia.beta.wmflabs.org/wiki/Copy-paste6th"></head><body data-parsoid="{"dsr":[0,277,0,0]}"><a href="./Link_to_catapult" rel="mw:WikiLink" data-parsoid="{"stx":"simple","a":{"href":"./Link_to_catapult"},"sa":{"href":"link to catapult"},"dsr":[0,20,2,2]}">link to catapult</a>

<a href="./LinkA" rel="mw:WikiLink" data-parsoid="{"stx":"simple","a":{"href":"./LinkA"},"sa":{"href":"linkA"},"dsr":[22,31,2,2]}">linkA</a>

<a href="./LinkB" rel="mw:WikiLink" data-parsoid="{"stx":"simple","a":{"href":"./LinkB"},"sa":{"href":"linkB"},"dsr":[33,42,2,2]}">linkB</a>

[<a href="http://en.wikipedia.beta.wmflabs.org/wiki/LinkC|linkC" rel="mw:ExtLink" data-parsoid="{"targetOff":99,"contentOffsets":[99,99],"dsr":[45,100,54,1]}"></a>]

<img class="tex" alt="\pi" src="//upload.beta.wmflabs.org/math/5/2/2/522359592d78569a9eac16498aa7a087.png" typeof="mw:Extension/math" data-mw="{"name":"math","attrs":{},"body":{"extsrc":"\\pi"}}" data-parsoid="{"src":"<math>\\pi</math>","dsr":[103,119,2,2]}" about="#mwt7">

text<span class="citation web" about="#mwt2" typeof="mw:Transclusion" data-mw="{"parts":[{"template":{"target":{"wt":"Cite web","href":"./Template:Cite_web"},"params":{"url":{"wt":"http://yahoo.com"},"title":{"wt":"yahoo"}},"i":0}}]}" data-parsoid="{"stx":"html","dsr":[125,174,null,null],"pi":[[{"k":"url","named":true},{"k":"title","named":true}]]}"><a rel="mw:ExtLink" href="http://yahoo.com" data-parsoid="{"targetOff":45,"contentOffsets":[45,52],"a":{"href":"http://yahoo.com"},"sa":{"href":"A]]\n\n[[linkB]]\n\n"}}">"yahoo"</a>.<span title="ctx_ver=Z39.88-2004&rfr_id=info%3Asid%2Fen.wikipedia.beta.wmflabs.org%3ACopy-paste6th&rft.btitle=yahoo&rft.genre=book&rft_id=http%3A%2F%2Fyahoo.com&rft_val_fmt=info%3Aofi%2Ffmt%3Akev%3Amtx%3Abook" class="Z3988" about="#mwt2" data-parsoid="{"stx":"html"}">

text

<img class="tex" alt="\pi" src="//upload.beta.wmflabs.org/math/5/2/2/522359592d78569a9eac16498aa7a087.png" typeof="mw:Extension/math" data-mw="{"name":"math","attrs":{},"body":{"extsrc":"\\pi"}}" data-parsoid="{"src":"<math>\\pi</math>","dsr":[182,198,2,2]}" about="#mwt9">

text

<img class="tex" alt="\pi" src="//upload.beta.wmflabs.org/math/5/2/2/522359592d78569a9eac16498aa7a087.png" typeof="mw:Extension/math" data-mw="{"name":"math","attrs":{},"body":{"extsrc":"\\pi"}}" data-parsoid="{"src":"<math>\\pi</math>","dsr":[206,222,2,2]}" about="#mwt11">

text<span class="citation web" about="#mwt5" typeof="mw:Transclusion" data-mw="{"parts":[{"template":{"target":{"wt":"Cite web","href":"./Template:Cite_web"},"params":{"url":{"wt":"http://yahoo.com"},"title":{"wt":"yahoo"}},"i":0}}]}" data-parsoid="{"stx":"html","dsr":[228,277,null,null],"pi":[[{"k":"url","named":true},{"k":"title","named":true}]]}"><a rel="mw:ExtLink" href="http://yahoo.com" data-parsoid="{"targetOff":45,"contentOffsets":[45,52],"a":{"href":"http://yahoo.com"},"sa":{"href":"A]]\n\n[[linkB]]\n\n"}}">"yahoo"</a>.<span title="ctx_ver=Z39.88-2004&rfr_id=info%3Asid%2Fen.wikipedia.beta.wmflabs.org%3ACopy-paste6th&rft.btitle=yahoo&rft.genre=book&rft_id=http%3A%2F%2Fyahoo.com&rft_val_fmt=info%3Aofi%2Ffmt%3Akev%3Amtx%3Abook" class="Z3988" about="#mwt5" data-parsoid="{"stx":"html"}"> <span typeof="mw:Transclusion" data-mw="{"parts":[{"template":{"target":{"wt":"Cite web","href":"./Template:Cite_web"},"params":{"url":{"wt":"http://yahoo.com"},"title":{"wt":"yahoo"}},"i":0}}]}" data-ve-no-generated-contents="true" class="citation web"></body></html>
page:Copy-paste6th
oldid:73736
format:json
Response Headersview source
Accept-Ranges:bytes
Age:0
Cache-control:private
Connection:keep-alive
Content-Encoding:gzip
Content-Length:97
Content-Type:application/json; charset=utf-8
Date:Tue, 07 Jan 2014 01:12:09 GMT
Server:Apache
Vary:Accept-Encoding
Via:1.1 varnish, 1.1 varnish
X-Cache:deployment-cache-text1 miss (0), deployment-cache-text1 frontend miss (0)
X-Content-Type-Options:nosniff
X-Frame-Options:SAMEORIGIN
X-Powered-By:PHP/5.3.10-1ubuntu3.9+wmf1
X-Varnish:239733000, 2143990872
X-Vary-Options:Accept-Encoding;list-contains=gzip

In ryasmeen's HTML dump the last paragraph contains both the text and the pasted citation. Apparently the VE rendering showed the citation in a separate line, so the discrepancy in the HTML emitted by VE (citation actually in the preceding paragraph) seems to be a bug in VE. Moving this to VE for that reason.

Jdforrester-WMF added a project: VisualEditor-DataModel.Nov 23 2014, 10:42 PM

Jdforrester-WMF set Security to None.

Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.

	F12624: Screen_Shot_2014-01-06_at_2.41.28_PM.png
	Nov 22 2014, 2:36 AM

New line at end of document sometimes merged into previous line on pasteOpen, MediumPublicActions

Description

Details

Event Timeline

New line at end of document sometimes merged into previous line on paste
Open, MediumPublic
Actions