Page MenuHomePhabricator
Create Task
Maniphest T60706

Add confirmation message after accepting/rejecting translator applications
Closed, ResolvedPublic
Actions

Description

In ManageTranslatorSandbox, when approving or rejecting a translator, add a notification that shows that "User X was approved/rejected". This adds some feedback about what happened. Proposing to show that notification for 5 seconds.

Details

Reference
bz58706
SubjectRepoBranchLines +/-
Add confirmation boxmediawiki/extensions/Translatemaster+15 -1
Customize query in gerrit

Related Objects

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:37 AM
• bzimport added projects: MediaWiki-extensions-Translate, good first task.
• bzimport set Reference to bz58706.
• bzimport added a subscriber: Unknown Object (MLST).
siebrand created this task.Dec 19 2013, 7:50 PM
Nemo_bis added a subscriber: Language-Team.Dec 2 2014, 10:14 AM
Nemo_bis renamed this task from Add notification after accepting/rejecting translator applications to Add confirmation message after accepting/rejecting translator applications.Jan 1 2015, 3:16 PM
Nemo_bis set Security to None.
Nemo_bis mentioned this in T100259: PHP Warning: implode(): Invalid arguments passed in ApiTranslateSandbox.php on line 170.May 25 2015, 8:09 AM
Nikerabbit moved this task from Backlog to Stash/Sandbox on the MediaWiki-extensions-Translate board.Apr 20 2016, 11:46 AM
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptApr 20 2016, 11:46 AM
Danny_B added a project: Language-Team.Jul 26 2016, 11:52 PM
Danny_B removed subscribers: • wikibugs-l-list, Language-Team.
Ashutosh1206 claimed this task.Oct 2 2016, 11:07 AM
Aklapper subscribed.Dec 15 2016, 3:15 PM

@Ashutosh1206: This issue has been assigned to you two months ago.
Could you please share a status update? Are you still working (or still plan to work) on this issue? Is there anything that others could help with?
Only in case you do not plan to work on this issue anymore, should you be removed as assignee (via 'Assign / Claim' in the 'Actions' dropdown menu)?

Aklapper removed Ashutosh1206 as the assignee of this task.Jan 25 2017, 7:06 PM
Aklapper removed a project: Language-Team.
Aklapper added a subscriber: Ashutosh1206.

@Ashutosh1206: I am resetting the assignee of this task because there have been no signs of progress lately (please correct me if I'm wrong).
Resetting the assignee avoids the impression that somebody is already working on fixing this task and it also allows anybody else to potentially work towards fixing this task.
Please claim this task again when you plan to fix this task (via 'Assign / Claim' in the 'Actions' dropdown menu) - it would be very welcome!
Thanks for your understanding!

DatGuy subscribed.Jan 25 2017, 7:25 PM

A simple popup button with confirm is fine @Aklapper ?

Aklapper added a comment.Jan 25 2017, 9:10 PM

@DatGuy: I can't answer that. I'm not a maintainer. :)

DatGuy added a comment.Jan 25 2017, 9:12 PM

Just wondering if that's what a person more familiar with UI would like. Who can assign these permissions, Commons sysops or stewards? I'll ask three what they'd prefer.

gerritbot subscribed.Jan 26 2017, 6:18 PM

Change 334394 had a related patch set uploaded (by DatGuy):
Add confirmation box

https://gerrit.wikimedia.org/r/334394

gerritbot added a project: Patch-For-Review.Jan 26 2017, 6:18 PM
Nikerabbit updated the task description. (Show Details)Jan 31 2017, 2:25 PM
In T60706#2970427, @DatGuy wrote:

Just wondering if that's what a person more familiar with UI would like. Who can assign these permissions, Commons sysops or stewards? I'll ask three what they'd prefer.

It is only used by few admins at translatewiki.net, as far as I know.

gerritbot added a comment.Mar 6 2017, 3:42 PM

Change 334394 merged by jenkins-bot:
[mediawiki/extensions/Translate] Add confirmation box

https://gerrit.wikimedia.org/r/334394

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-03-07_(1.29.0-wmf.15)).Mar 6 2017, 4:00 PM
Nikerabbit closed this task as Resolved.Mar 6 2017, 4:16 PM
Nikerabbit assigned this task to DatGuy.
Nikerabbit removed a project: Patch-For-Review.
DatGuy added a comment.EditedMar 6 2017, 4:17 PM

Thanks!

Nikerabbit added a comment.Mar 6 2017, 4:44 PM

This page is not used on Wikimedia sites. I will deploy this to translatewiki.net soon.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL