Page MenuHomePhabricator
Create Task
Maniphest T60717

Instance 'delete' link doesn't always delete the ldap entry for an instance
Closed, ResolvedPublic
Actions

Description

The javascript api calls 'deleteInstance' on the instance object but skips the other steps that would otherwise be done in tryDeleteSubmit. This means we're leaking ldap host records.

Version: unspecified
Severity: normal

Details

Reference
bz58717

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:37 AM
• bzimport added a project: wikitech.wikimedia.org.
• bzimport set Reference to bz58717.
• bzimport added a subscriber: Unknown Object (MLST).
Andrew created this task.Dec 19 2013, 9:48 PM
Andrew added a comment.Dec 19 2013, 9:50 PM

Probably I should audit all of the API calls for similar problems.

Andrew added a comment.Dec 20 2013, 3:39 PM

Well.. I can't reproduce this today.

Andrew added a comment.Dec 27 2013, 6:53 PM

And now I can again. It's intermittent, the ldap delete is sometimes failing without explanation.

The good news, we are at least /trying/ to do the ldap delete in all cases. Well... maybe that's bad news.

Andrew added a comment.Mar 19 2014, 6:36 PM

It is intermittent. When it fails, the opendj log looks like this:

DELETE RES conn=2907494 op=3 msgID=4 result=50 message="The entry dc=i-0000019f.eqiad.wmflabs,ou=hosts,dc=wikimedia,dc=org cannot be deleted due to insufficient access rights" etime=0

Andrew added a comment.Mar 20 2014, 5:04 AM

This should be fixed by:

https://gerrit.wikimedia.org/r/119537
https://gerrit.wikimedia.org/r/119694
https://gerrit.wikimedia.org/r/119698

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL