Page MenuHomePhabricator
Create Task
Maniphest T60726

Echo: refactor duplicate icon handling code into getNotificationIconUrl()
Closed, ResolvedPublic
Actions

Description

formatters/BasicFormatter.php's format() and includes/EmailFormatter.php getNotifIcon() were already duplicating code to determine the URL of a notification icon. With the fix for bug 58705 it's 20 lines of identical code.

The only difference between them is getNotifIcon() calls wfExpandUrl(); this e.g. could be an optional parameter to a common function or method.

Version: master
Severity: normal

Details

Reference
bz58726
SubjectRepoBranchLines +/-
Refactor and unify icon URL logicmediawiki/extensions/Echomaster+111 -42
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedNoneT119713 Update Help:Notifications
 ResolvedNoneT114351 Better organisation for the Notification System
 ResolvedCatropeT64435 MediaWiki:Notification-thanks doesn't look nice when $2 is MediaWiki:Echo-no-title ("No page" shown)
 Resolved• jmatazzoniT73534 Frequently getting broken echo notifications: "was linked from [No page]"
 ResolvedCatropeT60234 Echo: User should not see a notification with raw wikitext " [[User:[Nobody]|[Nobody]]]" in it.
 ResolvedCatropeT52829 Echo notifications should show the page name instead of [No page] if the page was deleted
 OpenNoneT100528 Improve organization and control for Flow notifications (tracking + ideas)
 ResolvedNoneT113228 Better organization for the Notification panel
 ResolvedNoneT114357 Notifications panel: simplify notification items
 ResolvedmatthiasmullieT115418 API should expose enough structured data about notifications that frontend can render them
 ResolvedMooeypooT115419 OOUI widgets for new notification design
 ResolvedmatthiasmullieT115421 Allow secondary actions to have icons and subtitles/tooltips
 OpenFeatureNoneT66475 Make crosswiki bits and pieces truly global (tracking)
 InvalidWikinautT3932 [DO NOT USE] ENotif/EConfirm & further enhancements (tracking) [superseded by #MediaWiki-Email]
 ResolvedCatropeT3066 Please add cross-wiki talk page notification.
 ResolvedCatropeT114350 Notifications Panel: Support cross-wiki notifications
 DeclinedSBissonT55479 Notification emails should embed icons as data URIs
 ResolvedNoneT109984 Links in Flow Topic titles, are shown as links in the Echo flyout and email, for Thanks
 ResolvedLegoktmT107823 Rewrite EchoNotificationFormatter
 ResolvedLegoktmT60726 Echo: refactor duplicate icon handling code into getNotificationIconUrl()

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:38 AM
• bzimport added a project: Notifications.
• bzimport set Reference to bz58726.
• bzimport added a subscriber: Unknown Object (MLST).
• Spage created this task.Dec 20 2013, 2:40 AM
• werdna unsubscribed.Dec 10 2014, 5:18 PM
EBernhardson triaged this task as Lowest priority.Dec 12 2014, 10:26 PM
EBernhardson added a project: good first task.
EBernhardson set Security to None.
• Mattflaschen-WMF added a project: Technical-Debt.Jan 11 2015, 4:47 AM
• Mattflaschen-WMF subscribed.
Legoktm moved this task from Backlog to Needs code on the Notifications board.Jul 6 2015, 8:41 AM
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptJul 6 2015, 8:41 AM
Legoktm renamed this task from refactor duplicate code into getNotificationIconUrl() to Echo: refactor duplicate icon handling code into getNotificationIconUrl().Aug 5 2015, 5:23 PM
Legoktm claimed this task.
Legoktm mentioned this in T107823: Rewrite EchoNotificationFormatter.
Legoktm added a parent task: T107823: Rewrite EchoNotificationFormatter.
Legoktm added a project: Collaboration-Team-Archive-2015-2016.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 5 2015, 5:24 PM
Legoktm moved this task from Untriaged to In Development on the Collaboration-Team-Archive-2015-2016 board.Aug 5 2015, 5:31 PM
gerritbot subscribed.Aug 5 2015, 7:41 PM

Change 229475 had a related patch set uploaded (by Legoktm):
Refactor and unify icon URL logic

https://gerrit.wikimedia.org/r/229475

gerritbot added a project: Patch-For-Review.Aug 5 2015, 7:41 PM
Legoktm moved this task from In Development to Needs Review on the Collaboration-Team-Archive-2015-2016 board.Aug 5 2015, 7:51 PM
Catrope closed this task as Resolved.Aug 6 2015, 4:20 AM
Catrope moved this task from Needs Review to Done on the Collaboration-Team-Archive-2015-2016 board.
gerritbot added a comment.Aug 6 2015, 4:22 AM

Change 229475 merged by jenkins-bot:
Refactor and unify icon URL logic

https://gerrit.wikimedia.org/r/229475

Diffusion mentioned this in rMEXT1fe01d4b7842: Updated mediawiki/extensions Project: mediawiki/extensions/Echo….Aug 6 2015, 4:22 AM
Catrope mentioned this in rECHO5e2da7627b41: Refactor and unify icon URL logic.Aug 6 2015, 4:22 AM
• Forrestbot added a project: WMF-deploy-2015-08-11_(1.26wmf18).Aug 6 2015, 5:00 AM
Danny_B added a parent task: T114350: Notifications Panel: Support cross-wiki notifications.Jul 20 2016, 1:21 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptNov 18 2018, 12:52 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL