Page MenuHomePhabricator

Editing (or any action) a post hides all its (descendant) replies
Closed, ResolvedPublic

Description

After submitting an action via JS, the api request responds with rendered HTML, which JS then replaces the old HTML with.

However, loadRequestedRevision (in Topic.php) doesn't load the full tree here, but only the post & root post (= topic). So, no children. It replaces the post and all of its child replies, by just the new post HTML (without child replies)

Either we make sure loadRequestedRevision always loads the full tree, or we change JS to make sure only the post (and no children) are replaces (a little tricky because they're nested inside the post's DOM)


Version: unspecified
Severity: normal

Details

Reference
bz58747

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:40 AM
bzimport set Reference to bz58747.
bzimport added a subscriber: Unknown Object (MLST).

bingle-admin wrote:

The WMF core features team tracks this bug on Mingle card https://mingle.corp.wikimedia.org/projects/flow/cards/646, but people from the community are welcome to contribute here and in Gerrit.

Change 104910 had a related patch set uploaded by Werdna:
When executing an action on a post, just replace the .flow-post, not the whole .flow-post-container.

https://gerrit.wikimedia.org/r/104910

Change 104910 merged by jenkins-bot:
When executing an action on a post, just replace the .flow-post, not the whole .flow-post-container.

https://gerrit.wikimedia.org/r/104910

Ricordisamoa renamed this task from Editing (or any action) a post hides all it's (descendant) replies to Editing (or any action) a post hides all its (descendant) replies.Mar 17 2015, 9:57 AM
Ricordisamoa updated the task description. (Show Details)
Ricordisamoa set Security to None.
Ricordisamoa subscribed.