Page MenuHomePhabricator
Create Task
Maniphest T60772

common gating job for mediawiki core and extensions
Closed, ResolvedPublic
Actions

Description

Now that Zuul gate-and-submit pipeline is a dependent pipeline, we can have different projects to share a common job. That would ensure extensions are tested properly, they will not be merged until previous changes being tested for master have passed.

Version: wmf-deployment
Severity: enhancement

Details

Reference
bz58772

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedhasharT60772 common gating job for mediawiki core and extensions
 DeclinedFeatureNoneT60771 Jenkins: MediaWiki extensions phpunit test should also run mediawiki core tests
 ResolvedhasharT69216 Have unit tests of all wmf deployed extensions pass when installed together, in both PHP-Zend and HHVM (tracking)
 ResolvedNoneT57886 CLDR breaks core timestamp tests
 DeclinedNoneT70231 wfWikiID() returns different values from test and data provider
 ResolvedNoneT68937 HHVM: TemplateDataBlobTest::testGetDataInLanguage fails with "Invalid operand type was used: expecting an array"
 ResolvedNoneT68942 HHVM: assertion from optimizedCallIniGet
 ResolvedNoneT68943 HHVM: Assertion in Scribunto_LuaEngine::callParserFunction() during uksort() call
 ResolvedNoneT69036 SpecialPagesTest::testSpecialPage errors with: array_merge() expects at least 1 parameter, 0 given
 ResolvedNoneT69043 Enabling SpamBlacklist breaks EditPageTest in core
 DeclinedNoneT69060 Gadgets: Fix failing unit test "GadgetsTest::testPreferences: isset( $options['<gadget-section-keep-section2>'] )"
 InvalidNoneT70629 PHP Notice: Undefined index: REQUEST_TIME in extensions/EventLogging/includes/EventLogging.php on line 56
 ResolvedNoneT70634 Exception: .agora-field-styling is undefined: failed at `.agora-field-styling();`
 OpenNoneT70636 No enabled connection [Called from CirrusSearch\ElasticsearchIntermediary::failure in /srv/vagrant/mediawiki/extensions/CirrusSearch/includes/ElasticsearchIntermediary.php at line 97]
 InvalidTptT70644 phpunit failure: Pages::testParserTest: Failed asserting that two strings are equal.
 ResolvedNoneT70646 phpunit failure: LuaStandalone: TitleLibraryTests: Failed asserting that two strings are identical
 ResolvedNoneT69139 BetaFeatures: Unit tests trigger notices in MobileFrontend
 ResolvedNoneT69138 BetaFeatures: AutoEnrollmentTest produce a fatal error with OATHAuth extension
 OpenNoneT70648 phpunit failure: Module prefix '' is shared between ApiQueryProofread and ApiTranscodeStatus
 ResolvedNoneT69142 ZeroPortal unit tests throws Warning: JsonConfig: Invalid $wgJsonConfigs['JsonZeroConfig']['url']: API URL is not set ...
 ResolvedNoneT70649 phpunit failure: ParserTests::testParserTest for gallery and files with UploadWizard and data-file-*
 InvalidNoneT70652 phpunit failure: Magic Word: {{NUMBEROFFILES}} Failed asserting that two strings are equal.
 InvalidNoneT70651 phpunit failure: UserTest::testAllRightsWithMessage with some additional rights
 OpenNoneT70654 phpunit failure: ApiOptionsTest::testReset User::saveSettings() was not expected to be called more than once
 ResolvedNoneT69148 Math tests dies when run with the Echo extensions
 ResolvedEBernhardsonT70655 Flow: Fix phpunit failure in SpamBlacklistTest::testSpam
 Invalid• demonT70672 hhvm: SolrTTMServerTest::testSearchableTTMServer BadMethodCallException: Call to a member function getMessage() on a non-object (NULL)
 ResolvedNoneT70697 PHP Fatal error: Call to a member function getContentModel() on a non-object in /srv/vagrant/mediawiki/extensions/Wikibase/repo/Wikibase.hooks.php on line 1005
 DeclinedNoneT70699 TemplateData.hooks.php:71: MWException: Invalid callback in hooks for ParserFirstCallInit
 InvalidNoneT70700 phpunit failure: TitlePermissionTest
 ResolvedNoneT69296 oauth_registered_consumer table not created under sqlite
 DeclinedNoneT69295 Fatal error: Call to a member function getMessage() on a non-object in /mediawiki/extensions/Translate/tag/TranslatablePage.php on line 253
 ResolvedNoneT70491 HHVM Failed Assertion: assertion `false && "Unsupported DataType"' failed.
 ResolvedhasharT69297 unittest_oathauth_users table not created under sqlite
 ResolvedReedyT69300 GlobalBlocking is lacking a database installer/updater
 OpenNoneT69302 MultimediaViewer thumbnailBeforeProduceHTML hook breaks other extensions parser tests
 ResolvedNoneT69353 GlobalBlocking cause other extensions tests to fail (globalblocking database not found)
 ResolvedNoneT69366 PageTriage: test fail ArticleMetadataTest::testValidatePageId MWException: DatabaseBase::makeList: empty input for field ptrp_page_id
 ResolvedJdforrester-WMFT70956 VisualEditor: ResourcesTest::testUnsatisfiableDependencies: The module 'mobile.editor.ve' must not have target 'desktop'
 ResolvedNikerabbitT70955 ResourcesTest::testMissingDependencies: Failed asserting that an array contains 'schema.UniversalLanguageSelector'.
 OpenNoneT70957 phpunit failure: Scribunto_LuaStandaloneInterpreterTest::testTimeLimit
 ResolvedNoneT70958 hhvm: BadMethodCallException: Call to a member function getOption() on a non-object
 ResolvedhasharT67875 AccountAudit does not pass Jenkins unit tests
 ResolvedhasharT67876 CommunityVoice does not pass Jenkins unit tests (sqlite compatibility)
 ResolvedhasharT67877 CreditsSource does not pass Jenkins unit tests (sqlite compatibility)
 ResolvedLegoktmT67895 OAI does not pass Jenkins tests (sqlite compatibility)
 ResolvedhasharT67896 TitleKey does not pass Jenkins unit tests (sqlite compatibility)
 ResolvedhasharT69598 EducationProgram dies if cldr is required after it
 DeclinedNoneT69608 EducationProgram test fail with permission error caused by WikimediaIncubator
 DeclinedNoneT69615 PageTriage: test SpecialNewPagesFeedTest::testAddArticles has 'Unknown error: "wminc-error-unprefixed"'
 ResolvedNoneT75521 Jenkins: Implement hhvm based voting jobs for mediawiki and extensions
 ResolvedhasharT73413 [OPS] hhvm 3.3.0-20140925+wmf3 has some annoying build dependency
 ResolvedhasharT75356 [OPS] Jenkins: Slaves running Ubuntu Trusty should have hhvm installed
 ResolvedJoeT75531 ApiFormatWddxTest::testValidSyntax fails in mediawiki-core-regression-hhvm-master test
 ResolvedJoeT84853 Build a new HHVM package
 ResolvedhasharT78166 MediaWiki tests using Tidy do not pass on HHVM
 ResolvedhasharT78556 hhvm on CI slaves can not find PEAR.php
 ResolvedEBernhardsonT78592 EchoTitleLocalCacheTest::testGet fails when tests are run with other extensions
 ResolvedQChrisT78680 EventLogging ValidateSchemaTest::testValidEvent() fails under HHVM
 ResolvedLegoktmT101392 Trigger PHPUnit job for MediaWiki extensions with HHVM instead of Zend in 'test' pipeline
 ResolvedhasharT101382 Only run Wikibase Zend Jenkins jobs on gate-and-submit
 Duplicate• Mattflaschen-WMFT103346 phpunit hhvm failure: LuaSandbox: TextLibraryTests[87]: json decode, invalid values (trailing comma)
 InvalidRyasmeenT90647 Create Jenkins builds for Editing across repositories (MobileFrontend, VisualEditor etc)
 ResolvedhasharT47499 [EPIC] Run CI jobs in disposable VMs
 ResolvedhasharT55594 Jenkins: Configure jobs to be runnable on any slaves
 ResolvedhasharT55683 [OPS] publish Zuul git repositories over git protocol
 ResolvedhasharT56762 find a way to deploy PHPUnit on production machines
 ResolvedhasharT58317 Jenkins: Use phpunit from deployment system (srv/deployment/integration/phpunit) instead of local pear install
 DuplicateNoneT55978 Create labs project for continuous integration nodepool
 Resolvedbd808T53556 Investigate Linux containers
 DuplicateNoneT84988 Create labs project for CI disposables instances + OpenStack API credentials
 DeclinedNoneT84989 Support dedicating a specific virt node to a specific nova project
 DeclinedhasharT84940 Acquire old production API servers for use in CI
 ResolvedhasharT85933 Evaluate JClouds Jenkins plugin
 DeclinedNoneT86168 Isolate contintcloud nova project from the rest of the wmflabs cloud
 Declined• chasempT85611 Neutron networking, with IPv6 at eqiad
 DeclinedNoneT85609 Labs available in the new data centre (with Neutron/IPv6)
 ResolvedcorenT85605 Set storage service up in codfw
 InvalidhasharT86172 Write a migration plan for CI infra to the disposable VMs infrastructure
 ResolvedhasharT86171 Design the Jenkins isolation architecture
 DeclinedhasharT97472 Create a Trusty labs image for CI isolation project
 Resolved• CmjohnsonT86658 Phase out lanthanum.eqiad.wmnet
 Resolved• CmjohnsonT105901 wipe disks for lanthanum
 ResolvedhasharT86659 Migrate all jobs to labs slaves
 ResolvedKrinkleT86175 Migrate jsduck jobs to run in labs (and jsduck-publish via integration-publisher)
 ResolvedKrinkleT86174 Migrate JSDuck to Ubuntu Trusty
 ResolvedKrinkleT93143 Migrate .*testextension-zend jobs to labs slaves
 ResolvedhasharT93559 Migrate mediawiki-core-code-coverage job to labs
 ResolvedKrinkleT93558 Add publishing macro for integration.wikimedia.org/cover
 ResolvedhasharT96463 Move integration-zuul-layout* jobs to labs slaves
 ResolvedhasharT95675 Migrate Jenkins job "Global-Dev Dashboard Data" to JJB and Zuul trigger
 ResolvedhasharT98737 Migrate operations-dns-lint Jenkins job to labs instances
 ResolvedhasharT101966 Remove use of label "hasSlaveScripts" in jobs
 ResolvedhasharT87294 Nodepool images need Gerrit mirror for git-clone performance
 ResolvedAndrewT113394 Evaluate impact of giant VM images on labs infrastructure
 ResolvedKrinkleT91996 Consolidate jobs to test entry points
 ResolvedhasharT91997 Replace project-specific "{name}-thing" jobs with generic "thing" ones
 ResolvedKrinkleT91854 Migrate jsduck-publish to use a single job and variable destination path
 ResolvedPaladoxT90943 Convert existing legacy phpcs jobs to use composer entry point + versioning
 ResolvedLegoktmT91176 Create composer validate --no-check-publish job for MediaWiki extensions
 ResolvedLegoktmT92557 Create generic "tox" jobs
 ResolvedLegoktmT94326 Create generic qunit job for MediaWiki extensions
 ResolvedLegoktmT94327 Create generic phpunit job for MediaWiki extensions
 ResolvedPaladoxT126682 Convert all MediaWiki extension phpunit jobs to use generic jobs
 ResolvedLegoktmT127362 Switch passing mwext-*-jslint jobs to jshint/jsonlint
 ResolvedLegoktmT96690 Have extensions with dependencies use the generic mwext-testextension-* job
 ResolvedhasharT109913 [keyresult] boot instances from OpenStack API
 ResolvedhasharT86170 OpenStack API account to control `contintcloud` labs project
 ResolvedyuvipandaT86167 Create labs project for CI disposables instances
 OpenNoneT86930 Add i18n related extensions to the CI gate
 ResolvedJdforrester-WMFT225068 Add a PHPUnit group to skip test on gated CI runs

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:41 AM
• bzimport added a project: Continuous-Integration-Infrastructure.
• bzimport set Reference to bz58772.
• bzimport added a subscriber: Unknown Object (MLST).
hashar created this task.Dec 20 2013, 10:47 PM
hashar added a comment.Jul 3 2014, 1:23 PM

I have been working on this and wrote a command line utility that let us clone core + extensions with matching Zuul Ref or branch. It is being experimented.

Running the unit tests with all extensions do not really work well which is bug 67216 "Have unit tests of all wmf deployed extensions pass when installed together, in both PHP-Zend and HHVM (tracking)"

gerritbot added a comment.Sep 18 2014, 1:04 PM

Change 161230 had a related patch set uploaded by Hashar:
Group MediaWiki job in the same gate queue

https://gerrit.wikimedia.org/r/161230

gerritbot added a comment.Sep 18 2014, 1:08 PM

Change 161230 merged by jenkins-bot:
Group MediaWiki jobs in the same gate queue

https://gerrit.wikimedia.org/r/161230

hashar added a comment.Sep 18 2014, 1:11 PM

mediawiki/core related jobs are now in the same gate queue by using the idle job mediawiki-gate

hashar added a comment.Nov 20 2014, 4:08 PM

I wrote a RFC explaining part of the future system at:

https://www.mediawiki.org/wiki/Requests_for_comment/Extensions_continuous_integration

Will be discussed during a RFC review session soonish.

• demon unsubscribed.Dec 16 2014, 6:05 PM
Krinkle added a comment.Dec 16 2014, 6:14 PM

Is this task ready to be closed?

hashar added a comment.Dec 17 2014, 9:17 AM

Not yet. We have the mediawiki-gate dummy jobs used to enforce MediaWiki related changes to share the same queue in the Zuul gate-and-submit pipeline.

That bug is about making it run tests for all extensions together. Will do the mobile extensions as a first step then slowly expand to the rest of the Wikimedia deployed extensions.

JanZerebecki subscribed.Feb 5 2015, 12:50 PM
hashar mentioned this in T94322: Re-evaluate use of "Dependent Pipeline" in Zuul for gate-and-submit.Mar 31 2015, 2:29 PM
Krinkle moved this task from Untriaged to Backlog on the Continuous-Integration-Infrastructure board.Apr 13 2015, 4:53 PM
hashar closed this task as Resolved.Apr 17 2019, 2:27 PM
hashar claimed this task.

I don't think we need this task anymore. That is nowadays the wmf-quibble jobs.

hashar closed subtask T69216: Have unit tests of all wmf deployed extensions pass when installed together, in both PHP-Zend and HHVM (tracking) as Resolved.Aug 23 2019, 2:26 PM
hashar closed subtask T60771: Jenkins: MediaWiki extensions phpunit test should also run mediawiki core tests as Declined.Fri, Mar 29, 3:02 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL