Page MenuHomePhabricator

MediaViewer conflicts with Zero
Closed, ResolvedPublic

Description

With ZeroRatedMobileAccess enabled clicking on an image opens the image preview as well as the interstitial which is supposed to protect you from loading.

We should think carefully about how we can support both.


Version: unspecified
Severity: normal

Details

Reference
bz58778

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:14 AM
bzimport set Reference to bz58778.
bzimport added a subscriber: Unknown Object (MLST).

bingle-admin wrote:

Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1572

Nice catch. Beta is disabled in W0, so we're safe in prod for now. For prioritization, how far off is productionization of the media viewer?

(In reply to Jon from comment #3)

Did we fix this? I forget..

Not sure. How far off is media viewer going to stable?

(In reply to Andre Klapper from comment #5)

Don't know "stable", but MediaViewer will go live on en.wp next week:
https://en.wikipedia.org/wiki/Wikipedia:
Village_pump_%28technical%29#Media_Viewer_launches_next_week_on_the_English_W
ikipedia

Will that include the mobile web?

(In reply to dr0ptp4kt from comment #6)

(In reply to Andre Klapper from comment #5)

MediaViewer will go live on en.wp next week

Will that include the mobile web?

No idea - the Multimedia team should be able to tell. CC'ing Fabrice.

No this is completely different code. I suspect it might be released before the tablet redirect so as not to remove any functionality. Maryana would be able to confirm on that.

The story to move the mobile media viewer to stable is currently marked for *after* the tablet redirect happens, which, as far as I can gather from reading this bug, is precisely what we want, right? If it causes issues for WP0 users, we shouldn't push it to stable until those issues are resolved. (Please feel free to correct me if I'm reading this wrong!)

This went live so I'm assuming the Zero issue got fixed or there is a bug reporting brokenness