Page MenuHomePhabricator

"Edit count" feature is broken (again) on Commons
Closed, ResolvedPublic

Description

When trying to use the edit count feature on Wikimedia Commons (for example, this URL for my account: http://tools.wmflabs.org/xtools/pcount/index.php?name=Peteforsyth&lang=commons&wiki=wikimedia ) one gets no meaningful results, but a page full of error messages, like this:

Notice: Undefined offset: 490 in /data/project/xtools/Graph.php on line 189

(followed by identical statements about different offset and line numbers).

This problem happened a few months ago, and was fixed; if I recall correctly, it had something to do with a new namespace being added on Commons. Is it possible to update the edit count tool so that it's not so sensitive to name space changes?


Version: unspecified
Severity: major

Details

Reference
bz58779

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:14 AM
bzimport set Reference to bz58779.

btw, 460 = Campaign namespace

I found the prior bug: 53494 (and assigned accordingly)

(In reply to comment #0)

When trying to use the edit count feature on Wikimedia Commons (for example,
this URL for my account:
http://tools.wmflabs.org/xtools/pcount/index.
php?name=Peteforsyth&lang=commons&wiki=wikimedia
) one gets no meaningful results, but a page full of error messages, like
this:

Notice: Undefined offset: 490 in /data/project/xtools/Graph.php on line 189

(followed by identical statements about different offset and line numbers).

This problem happened a few months ago, and was fixed; if I recall correctly,
it had something to do with a new namespace being added on Commons. Is it
possible to update the edit count tool so that it's not so sensitive to name
space changes?

Unfortunately no. Everytime a namespace is added, the edit counter will break because it is missing data for that namespace. What's missing is usually a color definition to assign the namespace to for graphing purposes. I'll have it fixed in just a few minutes.

But I'm starting to run out of distinctively different colors. :p

(In reply to comment #3)

(In reply to comment #0)

When trying to use the edit count feature on Wikimedia Commons (for example,
this URL for my account:
http://tools.wmflabs.org/xtools/pcount/index.
php?name=Peteforsyth&lang=commons&wiki=wikimedia
) one gets no meaningful results, but a page full of error messages, like
this:

Notice: Undefined offset: 490 in /data/project/xtools/Graph.php on line 189

(followed by identical statements about different offset and line numbers).

This problem happened a few months ago, and was fixed; if I recall correctly,
it had something to do with a new namespace being added on Commons. Is it
possible to update the edit count tool so that it's not so sensitive to name
space changes?

Unfortunately no. Everytime a namespace is added, the edit counter will
break
because it is missing data for that namespace. What's missing is usually a
color definition to assign the namespace to for graphing purposes. I'll have
it fixed in just a few minutes.

Surely it could handle the situation more gracefully (e.g. make all non-specified namespaces white or if unspecified take a hash of the namespace and derrive the colour from that)

(In reply to comment #5)

(In reply to comment #3)

(In reply to comment #0)

When trying to use the edit count feature on Wikimedia Commons (for example,
this URL for my account:
http://tools.wmflabs.org/xtools/pcount/index.
php?name=Peteforsyth&lang=commons&wiki=wikimedia
) one gets no meaningful results, but a page full of error messages, like
this:

Notice: Undefined offset: 490 in /data/project/xtools/Graph.php on line 189

(followed by identical statements about different offset and line numbers).

This problem happened a few months ago, and was fixed; if I recall correctly,
it had something to do with a new namespace being added on Commons. Is it
possible to update the edit count tool so that it's not so sensitive to name
space changes?

Unfortunately no. Everytime a namespace is added, the edit counter will
break
because it is missing data for that namespace. What's missing is usually a
color definition to assign the namespace to for graphing purposes. I'll have
it fixed in just a few minutes.

Surely it could handle the situation more gracefully (e.g. make all
non-specified namespaces white or if unspecified take a hash of the namespace
and derrive the colour from that)

I could, but that would make the problem go unnoticed. Also to have it set its own color could cause it to make extremely similar colors. Making the pi chart harder to read. I'd like to ensure the pi chart could be read by setting my own colors and making sure that they are different from each other. When the edit counter was still on toolserver, error suppression was switched on, suppressing all error messages. Hardly anybody noticed any issues. The edit counter was really broken though. So keeping error suppression off is the best way to make sure things are fixed and programmed correctly.