Page MenuHomePhabricator

Flow: Paging limit doesn't account for moderated topic
Open, HighPublic

Description

Hidden/deleted/suppressed topics that the user can't see, are filtered out.
Paging picks a certain # of topics and filters those out afterwards.
Instead of returning 10 posts, only 7 may be returned if 3 of them are moderated (and the user doesn't have permissions to see those)

This is a really minor issue, not worth spending much time on (imo).
We should just make sure that if *all* <limit> posts are moderated (and none are returned), the infinite scroll fires again.


Version: unspecified
Severity: normal

Details

Reference
bz58935

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 2:24 AM
bzimport set Reference to bz58935.
bzimport added a subscriber: Unknown Object (MLST).

bingle-admin wrote:

The WMF core features team tracks this bug on Mingle card https://mingle.corp.wikimedia.org/projects/flow/cards/656, but people from the community are welcome to contribute here and in Gerrit.

Change 106249 had a related patch set uploaded by Matthias Mullie:
Immediately trigger new scroll event after adding infinite scoll content

https://gerrit.wikimedia.org/r/106249

Above patch fixes the problem that infinite scroll doesn't fire again if no new visible feedback was loaded (because all of it was deleted)

Change 106249 merged by jenkins-bot:
Immediately trigger new scroll event after adding infinite scoll content

https://gerrit.wikimedia.org/r/106249

Bumping to increase priority.

Previously (months ago), it would load more topics if I rolled the mouse-scrollwheel.
Currently, it's not even doing that - at least at this page, which is short enough (whilst only showing one topic) to fit on my screen without any vertical scrollbar. https://www.mediawiki.org/wiki/Talk:Beta_Features/Hovercards

Created attachment 15491
screenshot

Confirming as still an issue, when the number of visible topics puts the "Older topics" link above the fold (ie. there's no vertical scrollbar), which might be because the topics are in "small view" collapsed mode, or because there just aren't many (undeleted) topics in the first ten.

Attached:

Screenshot_from_2014-05-27_14:22:42.png (1×1 px, 174 KB)

  • Bug 65897 has been marked as a duplicate of this bug. ***

Gerrit 106249 triggers a new scroll in JavaScript, but it doesn't seem to work on the initial page load, and it isn't as good as sending 10 visible topics at a time. Also, even for logged-in and admins who can see hidden (and deleted, and suppressed) topics, Flow should likewise try to load 10 "real" topics" in addition to possibly dozens of these hidden (deleted, suppressed) topics.