Missing unit tests for pywikibot library (tracking)
Closed, InvalidPublic
Actions

Description

DO NOT USE - Superseded by Pywikibot-tests

This is a task tracking unit tests that should be added, and provides instructions on how to find new unit tests that should be added . Adding unit tests is a simple way for new contributors to explore the library.

To find code not yet tested, browse https://codecov.io/github/wikimedia/pywikibot-core .

Some 'missing tests' information extracted from comments in the source code of the tests:

site_tests: ~~newimages~~, ~~longpages~~, ~~shortpages~~, ~~ancientpages~~, ~~unwatchedpages~~

page_tests: autoFormat, isAutoTitle (only partially done), getOldVersion, ~~getReferences~~, ~~backlinks~~, ~~embeddedin~~, getVersionHistory, getVersionHistoryTable, fullVersionHistory, contributingUsers

There are also some notes on using coverage at https://www.mediawiki.org/wiki/Manual:Pywikibot/Test_coverage#Library

Google Code-in clonable task description:

Browse [codecov analysis of Pywikibot](https://codecov.io/gh/wikimedia/pywikibot-core) and select a set of lines of code that are not yet exercised by the [extensive test suite](https://github.com/wikimedia/pywikibot-core/tree/master/tests). 
Add a unit test which exercises that set of lines of code to the test suite, and after the code is merged it will be automatically [tested on travis-ci](https://travis-ci.org/wikimedia/pywikibot-core/builds). 
[Create bug reports](https://www.mediawiki.org/wiki/How_to_report_a_bug) in [Wikimedia Phabricator](https://www.mediawiki.org/wiki/Phabricator/Help) for any relevant failures encountered. 
See the provided patch in Gerrit at https://gerrit.wikimedia.org/r/#/c/178891 as an example of this task.

The Phabricator task for tracking missing library tests is https://phabricator.wikimedia.org/T60941

Pywikibot is a Python-based framework to write bots for MediaWiki ([more information](https://www.mediawiki.org/wiki/Manual:Pywikibot). [Documentation on Gerrit is available](https://www.mediawiki.org/wiki/Manual:Pywikibot/Gerrit).

Mentors: @jayvdb

Details

Reference: bz58941

Subject	Repo	Branch	Lines +/-
[tests] add test for pywikibot.input_yn	pywikibot/core	master	+10 -11
[tests] Additional tests for UploadRobot	pywikibot/core	master	+26 -5
[tests] exclude some files and folders from code coverage	pywikibot/core	master	+4 -0
Create Module Tests	pywikibot/core	master	+90 -0
[TEST] Add tests for flow.Topic class	pywikibot/core	master	+31 -0
[TEST] Add tests to a bot account for User class	pywikibot/core	master	+6 -0
[TEST] Add tests for User class	pywikibot/core	master	+22 -0
[TEST] Add Test for site.botusers() method	pywikibot/core	master	+12 -0
Add tests for deprecated namespace shortcuts	pywikibot/core	master	+12 -0
Unit tests for Site.{long,short,ancient,unwatched}pages()	pywikibot/core	master	+47 -0
Remove lists of missing tests	pywikibot/core	master	+0 -24
Re-enable site tests commented out due to old bugs	pywikibot/core	master	+9 -9

Show related patches Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Invalid	None	T60941 Missing unit tests for pywikibot library (tracking)
Resolved	Unicodesnowman	T59602 pywikibot.Site.protect does not have unit tests
Resolved	Xqt	T67013 Test QueryGenerator.limit
Resolved	XZise	T67238 Add page comparison / equality unit tests
Resolved	jayvdb	T72336 Add script integration tests
Open	None	T78258 script test: python category.py move
Resolved	None	T60943 Archivebot: create unit tests for Timestripper
Resolved	XZise	T74681 copy JavaScript Title tests
Resolved	Unicodesnowman	T78231 Category methods members, subcategories and articles do not have unit tests
Resolved	murfel	T85321 Update BaseSite.urlEncode and create tests
Resolved	XZise	T85322 APISite.siteinfo signature different between compat and core
Declined	None	T193976 Missing unittests for botirc.py
Resolved	Xqt	T193977 Missing unittests for mysql.py
Resolved	Xqt	T193978 Missing unittests for cgi_interface.py
Resolved	Xqt	T129051 Pywikibot Echo tests
Resolved	Xqt	T247543 Missing unittests for several userinterface Option classes
Resolved	Xqt	T247659 maintenance/download_dump.py is not covered by any unittest
Resolved	Xqt	T247660 Some tests are not covered by codecov.io
Open	None	T85310 Add unit tests for MediaWiki, and Google SearchPageGenerator
Invalid	None	T137516 Add CI testing for upstream google library
Open	None	T305302 Provide tests for Lexeme classes

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

murfel closed subtask T85321: Update BaseSite.urlEncode and create tests as Resolved.Dec 12 2015, 6:51 AM

Change 261866 had a related patch set uploaded (by Sn1per):
Unit tests for Site.{long,short,ancient,unwatched}pages()

https://gerrit.wikimedia.org/r/261866

gerritbot added a project: Patch-For-Review.Jan 1 2016, 7:30 PM

Change 261866 merged by jenkins-bot:
Unit tests for Site.{long,short,ancient,unwatched}pages()

https://gerrit.wikimedia.org/r/261866

jayvdb removed a project: Patch-For-Review.Jan 10 2016, 2:02 PM

AndyTechGuy subscribed.Jan 20 2016, 7:22 PM

Change 265674 had a related patch set uploaded (by AndyTechGuy):
Add tests for deprecated namespace shortcuts

https://gerrit.wikimedia.org/r/265674

gerritbot added a project: Patch-For-Review.Jan 22 2016, 1:44 AM

Change 265674 merged by jenkins-bot:
Add tests for deprecated namespace shortcuts

https://gerrit.wikimedia.org/r/265674

jayvdb updated the task description. (Show Details)Jan 26 2016, 6:34 AM

jayvdb updated the task description. (Show Details)Jan 26 2016, 6:36 AM

Danny_B added a project: Technical-Debt.Jan 31 2016, 12:46 AM

Danny_B subscribed.

Danny_B unsubscribed.

AbdealiJK mentioned this in T129611: [GSoC 2016 Proposal] Port catimages.py to pywikibot-core.Mar 13 2016, 4:02 AM

Danny_B moved this task from Unsorted to Test coverage on the Technical-Debt board.Apr 21 2016, 8:55 PM

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptApr 21 2016, 8:55 PM

Danny_B renamed this task from [tracking] [clonable] Missing unit tests for pywikibot library to Missing unit tests for pywikibot library (tracking).May 27 2016, 6:00 PM

Danny_B removed a parent task: T60940: [DO NOT USE] Pywikibot tracking bugs (tracking) [superseded by #Pywikibot-Core].Jul 11 2016, 10:17 PM

Quiddity removed a parent task: T4007: [DO NOT USE] Tracking bug [superseded by #Tracking].Jul 14 2016, 4:19 AM

DrTrigon subscribed.Oct 31 2016, 7:51 PM

I will mentor this in Google-Code-In-2016

Ladsgroup removed a project: good first task.Nov 14 2016, 2:05 PM

Magul removed a project: Patch-For-Review.Nov 15 2016, 9:28 PM

jayvdb updated the task description. (Show Details)Nov 22 2016, 8:01 AM

jayvdb updated the task description. (Show Details)

jayvdb updated the task description. (Show Details)Nov 22 2016, 8:06 AM

@DrTrigon , the 2016 GCI task is here : https://codein.withgoogle.com/dashboard/tasks/5116835657678848/

jayvdb moved this task from Proposed tasks to Imported in GCI Site on the Google-Code-In-2016 board.Nov 22 2016, 8:09 AM

This one hasnt been published yet.

jayvdb updated the task description. (Show Details)Oct 23 2017, 6:10 AM

jayvdb added a project: Google-Code-in-2017.

jayvdb updated the task description. (Show Details)

Liuxinyu970226 subscribed.Nov 1 2017, 1:53 PM

Publsihed for 2017 as https://codein.withgoogle.com/tasks/4758358420619264/

Framawiki subscribed.Dec 8 2017, 11:07 PM

This comment was removed by Framawiki.

Framawiki mentioned this in T182473: codecov.io reports are broken.Dec 9 2017, 11:45 AM

Some subtasks are also listed in New tests needed column on Pywikibot-tests

Change 401083 had a related patch set uploaded (by Anpans; owner: Anpans):
[pywikibot/core@master] [TEST] Add Test for site.botusers() method

https://gerrit.wikimedia.org/r/401083

gerritbot added a project: Patch-For-Review.Dec 31 2017, 10:53 AM

Change 401083 merged by jenkins-bot:
[pywikibot/core@master] [TEST] Add Test for site.botusers() method

https://gerrit.wikimedia.org/r/401083

Change 401408 had a related patch set uploaded (by Framawiki; owner: Framawiki):
[pywikibot/core@master] [TEST] Add tests for User class

https://gerrit.wikimedia.org/r/401408

Dvorapa unsubscribed.Jan 1 2018, 10:25 PM

Change 401408 merged by jenkins-bot:
[pywikibot/core@master] [TEST] Add tests for User class

https://gerrit.wikimedia.org/r/401408

Change 402415 had a related patch set uploaded (by Framawiki; owner: Framawiki):
[pywikibot/core@master] [TEST] Add tests to a bot account for User class

https://gerrit.wikimedia.org/r/402415

Change 402415 merged by jenkins-bot:
[pywikibot/core@master] [TEST] Add tests to a bot account for User class

https://gerrit.wikimedia.org/r/402415

Change 405027 had a related patch set uploaded (by Framawiki; owner: Framawiki):
[pywikibot/core@master] [TEST] Add tests for flow.Topic class

https://gerrit.wikimedia.org/r/405027

Change 405027 merged by jenkins-bot:
[pywikibot/core@master] [TEST] Add tests for flow.Topic class

https://gerrit.wikimedia.org/r/405027

Framawiki removed a project: Patch-For-Review.Jan 20 2018, 2:10 PM

Change 404076 had a related patch set uploaded (by Eisenhaus335; owner: Eisenhaus335):
[pywikibot/core@master] Create Module Tests

https://gerrit.wikimedia.org/r/404076

gerritbot added a project: Patch-For-Review.Jan 23 2018, 6:52 AM

Change 404076 abandoned by Xqt:
Create Module Tests

Reason:
See my last comment

https://gerrit.wikimedia.org/r/404076

Mpaa reopened subtask T74681: copy JavaScript Title tests as Open.Feb 23 2018, 7:53 PM

Mpaa closed subtask T74681: copy JavaScript Title tests as Resolved.

Dvorapa moved this task from Backlog to Tracking tasks on the Pywikibot board.Mar 18 2018, 3:40 PM

Xqt mentioned this in T193968: Missing unittests for scripts (tracking).May 6 2018, 9:08 AM

Xqt added a subtask: T193976: Missing unittests for botirc.py.May 6 2018, 9:57 AM

Xqt added a subtask: T193977: Missing unittests for mysql.py.May 6 2018, 10:00 AM

Xqt added a subtask: T193978: Missing unittests for cgi_interface.py.May 6 2018, 10:12 AM

Xqt removed a project: Patch-For-Review.May 6 2018, 10:18 AM

Change 478731 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [tests] exclude some files and folders from code coverage

https://gerrit.wikimedia.org/r/478731

gerritbot added a project: Patch-For-Review.Dec 10 2018, 6:30 PM

Change 478731 merged by jenkins-bot:
[pywikibot/core@master] [tests] exclude some files and folders from code coverage

https://gerrit.wikimedia.org/r/478731

Xqt added a subtask: T129051: Pywikibot Echo tests.Jan 6 2019, 10:56 AM

Xqt closed subtask T129051: Pywikibot Echo tests as Resolved.Feb 8 2019, 5:06 AM

Xqt closed subtask T193976: Missing unittests for botirc.py as Declined.Aug 16 2019, 11:40 AM

Xqt added a subtask: T247543: Missing unittests for several userinterface Option classes.Mar 12 2020, 5:19 PM

Xqt removed a project: Patch-For-Review.Mar 12 2020, 10:28 PM

Xqt added a subtask: T247659: maintenance/download_dump.py is not covered by any unittest.Mar 14 2020, 11:40 AM

Xqt added a subtask: T247660: Some tests are not covered by codecov.io.Mar 14 2020, 11:55 AM

Xqt closed subtask T193978: Missing unittests for cgi_interface.py as Resolved.Mar 23 2020, 11:09 AM