Page MenuHomePhabricator

Profiling errors in CirrusSearchSearcher
Closed, ResolvedPublic

Description

I noticed these while hacking on the profiler:

<eventname><![CDATA[test2:-:Profiling error: in(CirrusSearchSearcher::fixupQueryStringPart), out(CirrusSearchSearcher::searchText-escape)]]></eventname>
<eventname><![CDATA[test2:-:Profiling error: in(CirrusSearchSearcher::searchText-build-query), out(CirrusSearchSearcher::fixupWholeQueryString)]]></eventname>
<eventname><![CDATA[test2:-:Profiling error: in(CirrusSearchSearcher::searchText-escape), out(CirrusSearchSearcher::searchText-build-query)]]></eventname>
<eventname><![CDATA[test2:-:Profiling error: in(CirrusSearchSearcher::searchText-switch-phrase-queries-to-plain), out(CirrusSearchSearcher::searchText-find-phrase-queries)]]></eventname>
<eventname><![CDATA[test2:-:Profiling error: in(CirrusSearchSearcher::searchText-switch-prefix-to-plain), out(CirrusSearchSearcher::searchText-switch-phrase-queries-to-plain)]]></eventname>


Version: unspecified
Severity: normal

Details

Reference
bz58987

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 2:28 AM
bzimport added a project: CirrusSearch.
bzimport set Reference to bz58987.

<eventname><![CDATA[test2:-:Profiling error:
in(CirrusSearchSearcher::fixupQueryStringPart),
out(CirrusSearchSearcher::searchText-escape)]]></eventname>

Found it.

<eventname><![CDATA[test2:-:Profiling error:
in(CirrusSearchSearcher::searchText-build-query),
out(CirrusSearchSearcher::fixupWholeQueryString)]]></eventname>

Found it.

<eventname><![CDATA[test2:-:Profiling error:
in(CirrusSearchSearcher::searchText-escape),
out(CirrusSearchSearcher::searchText-build-query)]]></eventname>

Couldn't find an error. I believe this is caused by the top two errors.

<eventname><![CDATA[test2:-:Profiling error:
in(CirrusSearchSearcher::searchText-switch-phrase-queries-to-plain),
out(CirrusSearchSearcher::searchText-find-phrase-queries)]]></eventname>

Found it.

<eventname><![CDATA[test2:-:Profiling error:
in(CirrusSearchSearcher::searchText-switch-prefix-to-plain),
out(CirrusSearchSearcher::searchText-switch-phrase-queries-to-plain)]]></eventname>

Found it.

Change 104031 had a related patch set uploaded by Manybubbles:
Fix profiling method calls

https://gerrit.wikimedia.org/r/104031

Change 104031 merged by jenkins-bot:
Fix profiling method calls

https://gerrit.wikimedia.org/r/104031