Page MenuHomePhabricator

REPORTS-30 Multi-line %wikis fails
Closed, ResolvedPublic

Description

This issue was converted from https://jira.toolserver.org/browse/REPORTS-30.
Summary: Multi-line %wikis fails
Issue type: Bug - A problem which impairs or prevents the functions of the product.
Priority: Major
Status: Resolved
Assignee: River Tarnell <river.tarnell@wikimedia.de>


From: River Tarnell <river.tarnell@wikimedia.de>

Date: Wed, 17 Sep 2008 22:10:47

When a multi-line %wikis ... %end is used, nightly fails because of incorrect splitting:

river@hemlock:~/tsreports>./nightly
mostrevisions
Traceback (most recent call last):
  File "./nightly", line 45, in <module>
    w = repdb.find_wiki_domain(context, wiki)
  File "/home/river/ts-reports/python/repdb.py", line 58, in find_wiki_domain
    raise ValueError('no such wiki')
ValueError: no such wiki

The problem is an empty string ends up in the wiki list, from the split at Reports.py:82.


Version: unspecified
Severity: major

Details

Reference
bz59043

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:31 AM
bzimport added a project: Tool-tsreports.
bzimport set Reference to bz59043.

From: River Tarnell <river.tarnell@wikimedia.de>

Date: Wed, 17 Sep 2008 22:48:14

Fixed by using a list comprehension to remove zero-length values.

This bug was imported as RESOLVED. The original assignee has therefore not been
set, and the original reporters/responders have not been added as CC, to
prevent bugspam.

If you re-open this bug, please consider adding these people to the CC list:
Original assignee: river@TCX.ORG.UK
CC list: river@TCX.ORG.UK