Page MenuHomePhabricator

use browser_label from env.rb instead of BROWSER_LABEL env var in Flow tests
Closed, InvalidPublic

Description

Reverted https://gerrit.wikimedia.org/r/#/c/104783/ because it requires that the BROWSER_LABEL environment variable be set, and this is not always true.

Instead, we should use the local definition of browser_label from support/env.rb:

def local_browser(user_agent)

if ENV['BROWSER_LABEL']
  browser_label = ENV['BROWSER_LABEL'].to_sym
else
  browser_label = :firefox
end

This requires making the browser_label variable available beyond the scope of of the local method.


Version: unspecified
Severity: normal

Details

Reference
bz59176

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 2:40 AM
bzimport set Reference to bz59176.

Related task is T63067. As far as I can see, the code from related commit no longer exists. If this is still a problem, please reopen. Closing as invalid.