Page MenuHomePhabricator

Update GeSHi to 1.0.8.12.
Closed, InvalidPublic

Description

Author: edward.dan.hart

Description:
GeSHi 1.0.8.12 is a minor update which adds support for more languages and has bug fixes for already existing languages.


Version: unspecified
Severity: enhancement

Details

Reference
bz59186

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:41 AM
bzimport added a project: SyntaxHighlight.
bzimport set Reference to bz59186.
bzimport added a subscriber: Unknown Object (MLST).

(In reply to comment #0)

GeSHi 1.0.8.12 is a minor update which adds support for more languages and
has
bug fixes for already existing languages.

This isn't a release yet... And looking in trunk, it's still versioned at '1.0.8.11'

No such download listed on http://sourceforge.net/projects/geshi/files/geshi/ hence nothing that can (currently) be done here. Request is welcome once such a tarball exists.

edward.dan.hart wrote:

(In reply to comment #2)

No such download listed on http://sourceforge.net/projects/geshi/files/geshi/
hence nothing that can (currently) be done here. Request is welcome once
such a
tarball exists.

BenBE migrated GeSHi to GitHub in November which is were you can find 1.0.8.12. (https://github.com/GeSHi/geshi-1.0)

Ah thanks! http://qbnz.com/highlighter/news.php?id=132 covers that.
But http://qbnz.com/highlighter/ still says "The latest stable version of GeSHi is 1.0.8.11" and "Downloads" links to http://sourceforge.net/projects/geshi/files/ . So what is the URL for a 1.0.8.12 tarball?

edward.dan.hart wrote:

what is the URL for a 1.0.8.12 tarball?

There doesn't appear to be one. I'm sorry, I assumed there was when I reported this bug. You can download the repo as a .zip (https://github.com/GeSHi/geshi-1.0/archive/master.zip) but it may be better for BenBE to properly tag it as a release.

A tarball isn't necessary, but a tag is pretty useful.

Chances are the version was bumped in master and development continued so people weren't reporting bugs in 1.0.8.11 that were there.

If there's a specific bugfix we could bring in the HEAD of master, and change the version to '1.0.8.12-cf5f2b' or similar. We have made minor modifications to the version currently in our repos to bring bugfixes.

Although we could track master as a git submodule, this becomes painful for WMF usage, as we'll need to have a copy of the repo in out care to use as a submodule, which then requires manual syncing/tracking of upstream.

Having said all that https://github.com/GeSHi/geshi-1.0/blame/master/src/geshi.php#L44 is still 1.0.8.11. So there isn't anything to do for this

edward.dan.hart wrote:

OK, then. Thanks for looking into this anyway.