Page MenuHomePhabricator

Flow: garbled phantom topic participants on ee-flow
Closed, ResolvedPublic

Description

weird topic box rendering from missing username

A lot of topics and posts on ee-flow had missing usernames. Then I ran update.php which applied workflow_user_ip field update, and I think things worked better. However, one topic still looks weird, screenshot attached. Note there's a blank username, and somehow in the topic box the flow-topic-participants "<blank> and Gry" turned into

<pre>and Gry
</pre>

Maybe the bad HTML isn't re-rendered. Unfortunately when I tried to add a new post to make Flow change it to "(anon, Gry, and spage)" I triggered bug 59197, so you can't see this topic any more.

Even if this is just a transient issue, maybe code somewhere could be more robust.


Version: master
Severity: normal
URL: http://ee-flow.wmflabs.org/w/index.php?title=Talk:Sandbox&workflow=050b9f659413f00fc8b1fa163e68c4ac

Attached:

2014-01-01_garbled_Flow_username.png (847×932 px, 127 KB)

Details

Reference
bz59198

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:42 AM
bzimport set Reference to bz59198.
bzimport added a subscriber: Unknown Object (MLST).

bingle-admin wrote:

The WMF core features team tracks this bug on Mingle card https://mingle.corp.wikimedia.org/projects/flow/cards/670, but people from the community are welcome to contribute here and in Gerrit.

http://ee-flow.wmflabs.org/w/index.php?title=Talk:Sandbox&workflow=050b9efcf0e3f00fc8b1fa163e68c4ac is another topic with a phantom (anonymous?) user, though it doesn't have the weird <pre> tag in the topic box.

Change 104930 had a related patch set uploaded by Matthias Mullie:
Automatically run FlowSetUserIp on update.php

https://gerrit.wikimedia.org/r/104930

There's a maintenance script: FlowSetUserIp.php, which will move all the ip data to the newly created columns.

This script was not automatically being run on update.php; I've submitted a patch to do so (https://gerrit.wikimedia.org/r/#/c/104930/).

For deployment, this is not a big issue, since update.php is not run. We'll have to make sure to manually run this maintenance script, though (and I've submitted another patch that fixes a minor bug in it: https://gerrit.wikimedia.org/r/#/c/104927/)

Change 104930 merged by jenkins-bot:
Automatically run FlowSetUserIp on update.php

https://gerrit.wikimedia.org/r/104930

Running FlowSetUserIp did clear it up.

The pre tag is due to the flow-topic-participants going through parse(), and in wikitext leading blanks format text as a <pre> tag. You can see this using eval.php:

echo wfMessage( 'flow-topic-participants', 2, 2, '', 'second person',

'third person' )->parse();

prints

<pre>and second person
</pre>