Page MenuHomePhabricator

MathLaTeXMLTest::testIntegration broken
Closed, ResolvedPublic

Description

Upon trying to merge a revision that didn't touch the actual running code or unit tests, it was noticed that the tests apparently currently in place are broken. This should be fixed

15:15:09 1) MathLaTeXMLTest::testIntegration
15:15:09 Rendering of a+b in plain Text mode
15:15:09 Failed asserting that two strings are equal.
15:15:09 --- Expected
15:15:09 +++ Actual
15:15:09 @@ @@
15:15:09 -'<span class="tex" dir="ltr" id="a_b"><math xmlns="http://www.w3.org/1998/Math/MathML" id="p1.1.m1" class="ltx_Math" alttext="a+b" xml:id="p1.1.m1.1" display="inline" xref="p1.1.m1.1.cmml"> <semantics xml:id="p1.1.m1.1a" xref="p1.1.m1.1.cmml"> <mrow xml:id="p1.1.m1.1.4" xref="p1.1.m1.1.4.cmml"> <mi xml:id="p1.1.m1.1.1" xref="p1.1.m1.1.1.cmml">a</mi> <mo xml:id="p1.1.m1.1.2" xref="p1.1.m1.1.2.cmml">+</mo> <mi xml:id="p1.1.m1.1.3" xref="p1.1.m1.1.3.cmml">b</mi> </mrow> <annotation-xml xml:id="p1.1.m1.1.cmml" encoding="MathML-Content" xref="p1.1.m1.1"> <apply xml:id="p1.1.m1.1.4.cmml" xref="p1.1.m1.1.4"> <plus xml:id="p1.1.m1.1.2.cmml" xref="p1.1.m1.1.2"/> <ci xml:id="p1.1.m1.1.1.cmml" xref="p1.1.m1.1.1">a</ci> <ci xml:id="p1.1.m1.1.3.cmml" xref="p1.1.m1.1.3">b</ci> </apply> </annotation-xml> <annotation xml:id="p1.1.m1.1b" encoding="application/x-tex" xref="p1.1.m1.1.cmml">a+b</annotation> </semantics> </math></span>'
15:15:09 +'<strong class='error'>Failed to parse(LaTeXML timeout from &#039;http://latexml.mathweb.org/convert&#039;): a+b</strong>
15:15:09 +'
15:15:09
15:15:09 /srv/ssd/jenkins-slave/workspace/mwext-Math-testextensions-master/extensions/Math/tests/MathLaTeXMLTest.php:134
15:15:09 /srv/ssd/jenkins-slave/workspace/mwext-Math-testextensions-master/tests/phpunit/MediaWikiTestCase.php:123
15:15:09 /srv/ssd/jenkins-slave/workspace/mwext-Math-testextensions-master/tests/phpunit/MediaWikiPHPUnitCommand.php:80
15:15:09 /srv/ssd/jenkins-slave/workspace/mwext-Math-testextensions-master/tests/phpunit/MediaWikiPHPUnitCommand.php:64
15:15:09


Version: unspecified
Severity: normal

Details

Reference
bz59212

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:15 AM
bzimport set Reference to bz59212.
bzimport added a subscriber: Unknown Object (MLST).

Change 104994 had a related patch set uploaded by Physikerwelt:
Skip LaTeXML integration tests

https://gerrit.wikimedia.org/r/104994

physik wrote:

Seems to be related to Jenkins, since the test work locally.
This test worked fine for month. But at some point in time Jenkins did no longer allow oubound connections to the webservice. Locally the test passes even today.
(Again a crucial point, that was hidden becaus the change to Math 2.0 was too big.)

The real fix is to use a http proxy which is made possible by injecting $wgHTTPProxy in MediaWiki configuration. That part is done via bug 59253 / https://gerrit.wikimedia.org/r/105198

Change 104994 abandoned by Physikerwelt:
Skip LaTeXML integration tests

Reason:
No longer needed:
See
Bug: 59253

https://gerrit.wikimedia.org/r/104994

Test change https://gerrit.wikimedia.org/r/#/c/105188/

The Math integration works so I guess $wgHTTPProxy is set properly \O/