Page MenuHomePhabricator

Implement retry in make-wmf-branch
Closed, ResolvedPublic

Description

When touching a lot of repos it's likely you'll get an error or 2.

When you're cloning 163 to make branches, chances are you'll hit an error. And you'll have to start again

e.g.

'git' 'clone' '-q' 'ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo.git' 'Echo'
Permission denied (publickey).
fatal: The remote end hung up unexpectedly
git exit with status 128

It would be useful if in the cases of certain errors (128 for example!) that we pause for a few seconds, then try again. In 99.9% of cases, this second attempt should work fine...


Version: unspecified
Severity: normal

Details

Reference
bz59213

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:15 AM
bzimport added a project: Deployments.
bzimport set Reference to bz59213.
bzimport added a subscriber: Unknown Object (MLST).

Change 104970 had a related patch set uploaded by Reedy:
WIP Retry commands if failed

https://gerrit.wikimedia.org/r/104970

Perfect example:

'git' 'clone' '-q' 'ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ZeroRatedMobileAccess.git' 'ZeroRatedMobileAccess'
Permission denied (publickey).
fatal: The remote end hung up unexpectedly
sleeping for 5
'git' 'clone' '-q' 'ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ZeroRatedMobileAccess.git' 'ZeroRatedMobileAccess'
Total 2551 (delta 1554), reused 2459 (delta 1546)
cd ZeroRatedMobileAccess
'git' 'branch' 'wmf/1.23wmf9'
'git' 'commit' '-a' '-q' '-m' 'Creating new wmf/1.23wmf9 branch'
'git' 'push' 'origin' 'wmf/1.23wmf9'
hash mismatch
key_verify failed for server_host_key
fatal: The remote end hung up unexpectedly
sleeping for 5
'git' 'push' 'origin' 'wmf/1.23wmf9'
Total 0 (delta 0), reused 0 (delta 0)
remote: Processing changes: closed: 516, refs: 1, done
To ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ZeroRatedMobileAccess.git

  • [new branch] wmf/1.23wmf9 -> wmf/1.23wmf9

Change 104970 merged by jenkins-bot:
Retry commands if failed

https://gerrit.wikimedia.org/r/104970

Assuming this bug is FIXED. If that is not the case: Please reopen and elaborate what is left to do here to get this report fixed.