Page MenuHomePhabricator

"PHP Notice"s from Special:RecentChanges from RecentChanges/Formatter.php
Closed, ResolvedPublic

Description

Visiting ee-flow's Special:RecentChanges seems to work, but generates a dozen or so notices in apache2/error.log, all like:

[Fri Jan 03 02:20:38 2014] [error] [client 216.38.130.164] PHP Notice: Undefined variable: row in /srv/mediawiki/extensions/Flow/includes/RecentChanges/Formatter.php on line 87
[Fri Jan 03 02:20:38 2014] [error] [client 216.38.130.164] PHP Notice: Trying to get property of non-object in /srv/mediawiki/extensions/Flow/includes/RecentChanges/Formatter.php on line 87
...

The same notices appear on-screen in my local wiki

Line 87 is

. $this->getActionDescription( $workflow, $row->blocktype, $revision, $user );

There's no $row variable in the file, but anything's possible with PHP trickery :)


Version: master
Severity: normal
URL: http://ee-flow.wmflabs.org/wiki/Special:RecentChanges

Details

Reference
bz59237

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:17 AM
bzimport set Reference to bz59237.
bzimport added a subscriber: Unknown Object (MLST).

bingle-admin wrote:

The WMF core features team tracks this bug on Mingle card https://mingle.corp.wikimedia.org/projects/flow/cards/678, but people from the community are welcome to contribute here and in Gerrit.

Change 105245 had a related patch set uploaded by EBernhardson:
Fix undefined variable in recentchanges formatter

https://gerrit.wikimedia.org/r/105245

Change 105245 merged by jenkins-bot:
Fix undefined variable in recentchanges formatter

https://gerrit.wikimedia.org/r/105245

Patch was merged, is this fixed now?