Page MenuHomePhabricator

DRTRIGON-131 Reduce bot_control.py influence, try to unlink features
Closed, ResolvedPublic

Description

This issue was converted from https://jira.toolserver.org/browse/DRTRIGON-131.
Summary: Reduce bot_control.py influence, try to unlink features
Issue type: Improvement - An improvement or enhancement to an existing feature or task.
Priority: Major
Status: Closed
Assignee: drtrigon <dr.trigon@surfeu.ch>


From: drtrigon <dr.trigon@surfeu.ch>

Date: Wed, 02 Jan 2013 21:46:37

Try to simplify functions and to unlink/move them from bot_control.py and put into framework upstream or bot scripts.

  • make the magicwords mechanism independent from bot_control.py by using subster_irc.py (which runs all the time) and connect to it by IRC channel (private communication) or alternatively by XML-RCP
  • error handler (with mail)
    • let the logging module do this, with help of class AdminEmailHandler
  • logger
    • e.g. move logging/logger stuff to wikipedia.py function log(...) (use '-log') and emulate 'info', 'warning', ... by using messages/text like "INFO: ...", "WARNING: ..." (as already done), ...
  • generic info and version output
  • several patches and work-a-rounds for other buggy code (e.g. py2.6)

The first point would also remove the need to run sum_disc.py, subster.py and others in sequence (one of the main reasons for bot_control.py) and allow to run them all in parallel (also because of new log file regime) and thus give more freedom for cron-job setup.


Version: unspecified
Severity: major

Details

Reference
bz59393

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:28 AM
bzimport set Reference to bz59393.

From: drtrigon <dr.trigon@surfeu.ch>

Date: Thu, 10 Jan 2013 16:51:09

magicwords mechanism replaced with a new (better) one in r459 and r460 (upstream r10878).


From: drtrigon <dr.trigon@surfeu.ch>

Date: Thu, 10 Jan 2013 21:55:59

version output (not generic info) partly introduced in trunk version.py but needs more work.

in rewrite version.py is a script thus a new module version.py (in pywikibot directory) has to be created and the important functions have to be moved from script to module. nothing done here.

edit: trunk and rewrite are both done now!


From: drtrigon <dr.trigon@surfeu.ch>

Date: Tue, 15 Jan 2013 18:50:47

Logging needs a format change in wikipedia.py in order to finally have the same log output format as rewrite. This change was already prepared but is still commented (out), confer r10931 (line 8750-8751).

Attention: this needs also a change in panel.py (that breaks compatibility) therefore archive and remove of ALL logs on server (TS) and then start with the new format.


From: drtrigon <dr.trigon@surfeu.ch>

Date: Mon, 21 Jan 2013 17:24:49

Please have also a look at http://de.wikipedia.org/wiki/Benutzer:DrTrigonBot/Status and the comment:

make the daily subster run independend of sum_disc in order to have good update here!


From: drtrigon <dr.trigon@surfeu.ch>

Date: Sun, 22 Sep 2013 10:32:31

Done.

Consider change from bot_control.py to pwb.py (compatibility with rewrite/core) as well as current crontab.

This bug was imported as RESOLVED. The original assignee has therefore not been
set, and the original reporters/responders have not been added as CC, to
prevent bugspam.

If you re-open this bug, please consider adding these people to the CC list:
Original assignee: dr.trigon@surfeu.ch
CC list: dr.trigon@surfeu.ch