Page MenuHomePhabricator

DRTRIGON-84 'botlist' and 'wikipedia' upstream need some bug fixes
Closed, ResolvedPublic

Description

This issue was converted from https://jira.toolserver.org/browse/DRTRIGON-84.
Summary: 'botlist' and 'wikipedia' upstream need some bug fixes
Issue type: Bug - A problem which impairs or prevents the functions of the product.
Priority: Major
Status: Resolved
Assignee: drtrigon <dr.trigon@surfeu.ch>


From: drtrigon <dr.trigon@surfeu.ch>

Date: Sat, 19 Feb 2011 08:37:33

  • 'botlist' crashes after mediawiki update of german wiki to 1.17wmf1 a patch was provided (but should be version dependent also)
  • 'wikipedia' has several methods in Page object to retrieve the mediawiki software number (e.g. 'version', 'live_version', ...) but the 'live_version' in the current revision has always to fall back to 'version' and the internally hard coded version string, which is not that useful

both patches were sent upstream to Xqt, for verification and commit.


Version: unspecified
Severity: major

Details

Reference
bz59529

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:37 AM
bzimport set Reference to bz59529.

From: drtrigon <dr.trigon@surfeu.ch>

Date: Sat, 19 Feb 2011 08:40:05

patches (without version check)


From: drtrigon <dr.trigon@surfeu.ch>

Date: Sat, 19 Feb 2011 08:44:54

A strange or interesting fact is the member function 'headerDone' (from class '_GetAll') is able to retrieve the 'live_version' also. It uses the other way; instead of using 'Special:Version' it processes the tags given in all (newer?) mediawiki page headers, like e.g.:

<meta name="generator" content="MediaWiki 1.17wmf1" />

to get the actual version. May be we should just use one single method in one single place to solve this...?!?


From: drtrigon <dr.trigon@surfeu.ch>

Date: Sat, 19 Feb 2011 08:46:54

(add one item)


From: drtrigon <dr.trigon@surfeu.ch>

Date: Sat, 19 Feb 2011 12:53:12

  • 'wikipedia' done in r8984
  • 'botlist' done in r8985

I have a follow-up for both of them, but it is not important for the bot to work.


From: drtrigon <dr.trigon@surfeu.ch>

Date: Sat, 19 Feb 2011 13:36:13

Follow-up patches proposed to Xqt. Not done yet, but not that important anyway.


From: drtrigon <dr.trigon@surfeu.ch>

Date: Sat, 19 Feb 2011 13:36:57

Followups not done yet, since not that important...


From: drtrigon <dr.trigon@surfeu.ch>

Date: Sat, 19 Feb 2011 13:38:30

http://svn.wikimedia.org/svnroot/pywikipedia/branches/rewrite/pywikibot/site.py

('live_version' in re-write uses generator meta tag already)

This bug was imported as RESOLVED. The original assignee has therefore not been
set, and the original reporters/responders have not been added as CC, to
prevent bugspam.

If you re-open this bug, please consider adding these people to the CC list:
Original assignee: dr.trigon@surfeu.ch
CC list: dr.trigon@surfeu.ch