Page MenuHomePhabricator

DRTRIGON-71 Merge DrTrigonBot clean_user_sandbox with clean_sandbox
Closed, ResolvedPublic

Description

This issue was converted from https://jira.toolserver.org/browse/DRTRIGON-71.
Summary: Merge DrTrigonBot clean_user_sandbox with clean_sandbox
Issue type: Sub-task - The sub-task of the issue
Priority: Major
Status: Closed
Assignee: drtrigon <dr.trigon@surfeu.ch>


From: drtrigon <dr.trigon@surfeu.ch>

Date: Sat, 13 Nov 2010 13:49:10

By looking at the source of clean_user_sandbox in [1] it can be seen that most of the code differences are within 'run()' of the bot class. Thus I would like to propose some slight adaptions in clean_sandbox in such a way, that e.g. the get and put operations can be omitted. May be the two codes can be completely merged/joned together.

If this is accepted I am willing to write the needed code.


Version: unspecified
Severity: major

Details

Reference
bz59536

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:37 AM
bzimport set Reference to bz59536.

From: drtrigon <dr.trigon@surfeu.ch>

Date: Thu, 03 Feb 2011 22:50:00

If adapted and then published upstream it may be possible that 'dtbext.basic.BasicBot' would also be needed, thus this has also to be adapted and sent upstream...


From: drtrigon <dr.trigon@surfeu.ch>

Date: Fri, 04 Feb 2011 14:51:16

wrong click!!!


From: drtrigon <dr.trigon@surfeu.ch>

Date: Fri, 04 Feb 2011 15:12:33

Done in r75: http://fisheye.toolserver.org/changelog/drtrigon/?cs=75

Waiting for upstream commit...


From: drtrigon <dr.trigon@surfeu.ch>

Date: Fri, 04 Feb 2011 22:55:11

In chat with xqt he came up with a few good ideas. Basically the user sandbox mode should be stand-alone.


From: drtrigon <dr.trigon@surfeu.ch>

Date: Fri, 04 Feb 2011 22:59:30

Done in r77: http://fisheye.toolserver.org/changelog/drtrigon/?cs=77

Again waiting for upstream...


From: drtrigon <dr.trigon@surfeu.ch>

Date: Mon, 07 Feb 2011 18:59:26

If this was done, may be add possibility for debug options (switch off writing to wiki). This could be implemented by using 'self.save()' from 'basic.BasicBot' and sub-classing/modifying it.


From: drtrigon <dr.trigon@surfeu.ch>

Date: Fri, 11 Feb 2011 10:56:54

Another idea to implement in future is to use backlinks to given template instead of user-list.


From: drtrigon <dr.trigon@surfeu.ch>

Date: Fri, 11 Feb 2011 10:57:18

Done in r101: http://fisheye.toolserver.org/changelog/drtrigon/?cs=101

Thanks to xqt!


From: drtrigon <dr.trigon@surfeu.ch>

Date: Tue, 30 Aug 2011 16:09:47

fixed version missing

This bug was imported as RESOLVED. The original assignee has therefore not been
set, and the original reporters/responders have not been added as CC, to
prevent bugspam.

If you re-open this bug, please consider adding these people to the CC list:
Original assignee: dr.trigon@surfeu.ch
CC list: dr.trigon@surfeu.ch