fixing_redirects.py: move treat() to pywikibot/textlib
Open, HighPublic
Actions

Assigned To

None

Authored By

	valhallasw
	Jan 5 2014, 5:27 PM

Description

def treat should be moved to pywikibot/textlib.py (as 'replaceLinks(text, fromPage, toPage)')

Version: core-(2.0)
Severity: normal

Details

Reference: bz59686

Subject	Repo	Branch	Lines +/-
[bugfix] Fix the behavior of fixing_redirects.py	pywikibot/core	master	+32 -106
[IMPR] Fix weirdly broken replace_links to behave more expectable	pywikibot/core	master	+158 -167
New textlib.replace_links() link replacements	pywikibot/core	master	+474 -84

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T60942 Features to move from scripts to framework (tracking)
Open	None	T151110 RFC: Regressions of core should be rethought or solved
Open	None	T61686 fixing_redirects.py: move treat() to pywikibot/textlib

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:20 AM

• bzimport added a project: Pywikibot-Scripts.

• bzimport set Reference to bz59686.

valhallasw created this task.Jan 5 2014, 5:27 PM

Change 137802 had a related patch set uploaded by Ricordisamoa:
move treat() out of fixing_redirects.py, as generic textlib.replaceLinks()

https://gerrit.wikimedia.org/r/137802

Aklapper added a project: Pywikibot.Nov 27 2014, 4:20 PM

Liuxinyu970226 subscribed.Dec 26 2014, 6:46 AM

Change 137802 had a related patch set uploaded (by XZise):
New textlib.replace_links() link replacements

https://gerrit.wikimedia.org/r/137802

In T61686#1218107, @gerritbot wrote:

Change 137802 had a related patch set uploaded (by XZise):

Reassigning accordingly.

I don't know why gerritbot commented again but as you can see the same patch (which is still authored by you) was reported by @gerritbot a year ago.

I cannot commit (pun intended) to that patch anymore. Feel free to place it back up for grabs.

jayvdb added a project: Pywikibot-textlib.py.Jun 9 2015, 7:45 AM

Change 137802 merged by jenkins-bot:
New textlib.replace_links() link replacements

https://gerrit.wikimedia.org/r/137802

XZise mentioned this in rPWBC18e6c9b1e655: New textlib.replace_links() link replacements.Jun 12 2015, 12:17 PM

jayvdb closed this task as Resolved.Jun 12 2015, 12:36 PM

Liuxinyu970226 unsubscribed.Jun 12 2015, 2:10 PM

reopened due to the revert with 8a7c42f50ac1c99b99d7cac9c because of the regression made by 18e6c9b1e655a807ce0ab732880c9874093cef1b

Xqt triaged this task as High priority.Oct 30 2016, 11:44 AM

Magul removed a project: Patch-For-Review.Nov 15 2016, 9:28 PM

Xqt mentioned this in T151110: RFC: Regressions of core should be rethought or solved.Nov 24 2016, 10:47 AM

Xqt added a parent task: T151110: RFC: Regressions of core should be rethought or solved.

Xqt removed XZise as the assignee of this task.May 26 2017, 5:42 AM

Xqt added a subscriber: XZise.

Change 491673 had a related patch set uploaded (by Dvorapa; owner: Dvorapa):
[pywikibot/core@master] [IMPR] Fix weirdly broken replace_links to behave more expectable

https://gerrit.wikimedia.org/r/491673

gerritbot added a project: Patch-For-Review.Feb 20 2019, 12:36 PM

Change 491884 had a related patch set uploaded (by Dvorapa; owner: Dvorapa):
[pywikibot/core@master] [bugfix] Fix the behavior of fixing_redirects.py

https://gerrit.wikimedia.org/r/491884

Change 491884 had a related patch set uploaded (by Dvorapa; owner: Dvorapa):
[pywikibot/core@master] [bugfix] Fix the behavior of fixing_redirects.py

https://gerrit.wikimedia.org/r/491884

Pppery edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.Mar 29 2023, 12:11 AM