Page MenuHomePhabricator

Edit form should keep track of what the latest revision was when editing began
Open, MediumPublic

Description

Currently, the edit form only keeps track of the latest timestamp when editing began. It should also track the latest revision (in a hidden field).


Version: 1.23.0
Severity: normal

Details

Reference
bz59694

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:20 AM
bzimport set Reference to bz59694.
bzimport added a subscriber: Unknown Object (MLST).

Note: The FlaggedRevs extension currently provides this functionality (frontend/FlaggablePageView.php FlaggablePageView::addRevisionIDField), but it is needed in core.

Actually, the functionality required is not completely identical. Editing with an oldid should still yield the latest ID at the time the edit begins, while in FlaggedRevs it becomes the oldid.

You mean to say to have another button to show the difference from last revision alongside the "Show changes" button which shows difference from the latest revision when editing began?

No. As I interpret it, the "Show changes" button should always show a diff of changes from when editing began. Otherwise (in the current situation), if someone else saved since you started editing, the diff is confusing and misleading.