Page MenuHomePhabricator

Need to login to upload files
Closed, ResolvedPublic

Description

Author: mediawiki

Description:
I've set the following lines in my LocalSettings.php file:

$wgGroupPermissions['*']['upload'] = true;
$wgGroupPermissions['*']['reupload'] = true;
$wgGroupPermissions['*']['reupload-shared'] = true;

but when I try to upload a file without logging in, I get the message saying
"You must be logged in to upload files."

Uploads work fine for logged-in users.


Version: unspecified
Severity: normal

Details

Reference
bz5970

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:13 PM
bzimport set Reference to bz5970.
bzimport added a subscriber: Unknown Object (MLST).

The logging infrastructure currently requires that users be
logged in to perform this action.

mediawiki wrote:

Is this going to be changed/updated?

rotemliss wrote:

*** Bug 6208 has been marked as a duplicate of this bug. ***

rotemliss wrote:

Patch (trunk)

This patch rewrites this piece of code, so that all the messages will be shown
only if the upload is forbidden; if the user is anonymous, a message tells him
to log in – and if not, a message tells him he should have a permission.

Attached:

rotemliss wrote:

Patch (REL1_6)

Please note that this fix should be also backported, as the bug is very
important for several wikis, and the fix is small. Thanks.

Attached:

rotemliss wrote:

We can even give an anonymous user the right to delete pages, or move them, or
block users – if we are crazy. Why can't we allow him to upload images, which is
much harmless feature?

However, I don't say it should be set by default (it absolutely shouldn't be
so), but it should be possible to set.

robchur wrote:

The fix will not be useful until the logging table contains the aforementioned field.

rotemliss wrote:

Applied to trunk in r16199.

(In reply to comment #7)

The fix will not be useful until the logging table contains the aforementioned

field.

You are right, however we shouldn't have such mistakes in the permissions
system, even if another bug makes them "legitimate". When the other bug is
fixed, we may forget to fix this small bug, for example.

rotemliss wrote:

*** Bug 7287 has been marked as a duplicate of this bug. ***

Gilles raised the priority of this task from Medium to Unbreak Now!.Dec 4 2014, 10:20 AM
Gilles added a project: Multimedia.
Gilles moved this task from Untriaged to Done on the Multimedia board.
Gilles lowered the priority of this task from Unbreak Now! to Medium.Dec 4 2014, 11:23 AM