Page MenuHomePhabricator

VisualEditor: Toolbar doesn't float properly in standalone demo
Closed, ResolvedPublic

Description

It either snaps to the top left of the screen (instead of lining up with the surface), or it tries to render with 0 width (especially if you switch page)


Version: unspecified
Severity: normal

Details

Reference
bz59720

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 2:22 AM
bzimport set Reference to bz59720.

I can't find a cause using git-bisect.

VisualEditor.git goes back to 20 Dec 2013, which already exhibits the problem.

Bisecting in mediawiki/extensions/VisualEditor.git also led to nothing as the problem was never present there to begin with.

I suspect the problem may be caused by us having removed a stylesheet in the repo split that is now in the ve-mw only, but should be under ve/ve instead.

Change 109489 had a related patch set uploaded by Esanders:
Attach container to DOM before initialising target in demo

https://gerrit.wikimedia.org/r/109489

Change 109489 merged by jenkins-bot:
Attach container to DOM before initialising target in demo

https://gerrit.wikimedia.org/r/109489

  • Bug 60183 has been marked as a duplicate of this bug. ***