It looks like the KeepGoing overlay was broken by https://gerrit.wikimedia.org/r/#/c/102043/.

Specifically, that change moved the overlay show() from KeepGoingOverlay::render() to the keepgoing.js instatiation (which only handles the 2nd half of the keepgoing workflow). The first step is handled in EditorOverlay.js (around line 233).

This could either be fixed by adding a show() in EditorOverlay.js or moving show() back into KeepGoingOverlay::render(). Putting it back in KeepGoingOverlay::render() seems the most sensible (after all, that's the function that is supposed to render the overlay). Is there a specific reason it was moved out of that function?

Version: unspecified
Severity: major