Page MenuHomePhabricator
Create Task
Maniphest T61748

Native browser interactive spell-check tool fails to get content into DM, just CE, in Safari
Closed, ResolvedPublic40 Estimated Story Points
Actions

Description

Intention:
Correct the spelling of a word.

Steps to Reproduce:

  1. Add some text, including a spelling error, to an article.
  2. Use Safari's built-in spellcheck to correct the spelling.

Actual Results:
The correct spelling displays on the screen. However, if you "review changes", only the old, incorrect spelling is present. Also, the correct spelling stops being displayed on the screen if you hit return to start a new paragraph or list item.

Screenshot shows the display and the review changes. Confirmed in both lists and plain paragraphs.

Reproducible: Always

Confirmed in Safari 6 on Mac OS 10.8.5 using Vector. It's not present in Firefox 26.

Version: unspecified
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=50822

Details

Reference
bz59748

Related Objects

Event Timeline

• bzimport raised the priority of this task from to High.Nov 22 2014, 2:24 AM
• bzimport added projects: Browser-Support-Apple-Safari, VisualEditor-ContentEditable.
• bzimport set Reference to bz59748.
• Whatamidoing-WMF created this task.Jan 7 2014, 12:58 AM
• Whatamidoing-WMF added a comment.Jan 7 2014, 12:59 AM

Created attachment 14242
VisualEditor screenshot, showing "Review changes" not matching the displayed text

Attached:

VisualEditor_does_not_accept_spellcheck_changes.png (505×863 px, 68 KB)

TheDJ added a comment.Jan 7 2014, 1:13 AM

Confirmed with Safari 7 on 10.9

Jdforrester-WMF added a project: VisualEditor.Nov 23 2014, 10:48 PM
Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.Nov 24 2014, 1:24 AM
Jdforrester-WMF renamed this task from VisualEditor: Using browser native interactive spell-check tool fails to make changes that get to the DM in Safari to Native browser interactive spell-check tool fails to get content into DM, just CE, in Safari.Dec 3 2014, 3:43 AM
Jdforrester-WMF mentioned this in T62839: Native Mac OS special character inserter fails to get content into DM, just CE, in Safari.
Jdforrester-WMF set Security to None.
• Whatamidoing-WMF added a comment.Dec 10 2014, 6:24 AM

I think we're making some progress on this. Today, the automatic spelling correction is visible in "Review changes". If the spelling change has the net effect of removing one character, then it even appears to be handled correctly. However, if it adds a character, then the change is not made, but an equivalent number of extra letters are repeated at the end.

Examples:

  • Typing "teh" and auto-correcting it to "the" displays correctly and saves correctly.
  • Typing "cantalop" and auto-correcting it to "cantaloup" (adding one character) is saved as "cantalopp" (last letter repeated; added 'u' missing).
  • Typing "proftabilty" and auto-correcting it to "profitability"(adding two characters) is saved as "proftabiltyty" (last two letters repeated; added two letters missing).
Krinkle unsubscribed.Dec 17 2014, 1:00 AM
Jdforrester-WMF moved this task from Freezer to External and Administrivia on the VisualEditor board.Jan 15 2015, 12:47 AM
Jdforrester-WMF added a project: VisualEditor 2014/15 Q3 blockers.Jan 23 2015, 11:32 PM
Jdforrester-WMF edited a custom field.Feb 2 2015, 8:00 PM
Jdforrester-WMF moved this task from Nominated to Accepted on the VisualEditor 2014/15 Q3 blockers board.Feb 3 2015, 5:05 PM
• TrevorParscal edited a custom field.Feb 4 2015, 7:13 PM
Jdforrester-WMF closed this task as Resolved.Feb 18 2015, 3:38 PM
Jdforrester-WMF claimed this task.
In T61748#836003, @Whatamidoing-WMF wrote:

I think we're making some progress on this. Today, the automatic spelling correction is visible in "Review changes". If the spelling change has the net effect of removing one character, then it even appears to be handled correctly. However, if it adds a character, then the change is not made, but an equivalent number of extra letters are repeated at the end.

Examples:

  • Typing "teh" and auto-correcting it to "the" displays correctly and saves correctly.
  • Typing "cantalop" and auto-correcting it to "cantaloup" (adding one character) is saved as "cantalopp" (last letter repeated; added 'u' missing).
  • Typing "proftabilty" and auto-correcting it to "profitability"(adding two characters) is saved as "proftabiltyty" (last two letters repeated; added two letters missing).

This also appears to now be fixed. Adding and removing characters works perfectly, in all three use cases here and others I tested.

Jdforrester-WMF moved this task from Accepted to Done on the VisualEditor 2014/15 Q3 blockers board.Feb 18 2015, 5:21 PM
Jdforrester-WMF moved this task from External and Administrivia to FY 18-19 Q3/Q4 on the VisualEditor board.Feb 21 2015, 12:37 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL