Page MenuHomePhabricator

Fix ugly mixed bold styles in Bugzilla fields in Wikimedia skin
Closed, ResolvedPublic

Description

Screenshot

Our local custom Wikimedia skin displays bug field captions with a seemingly random mix of bold and "double-bold" (black) text. See the screenshot (taken in Firefox, but the same output is seem in other browsers).

I think all these text labels, except perhaps the bug number in the header, should just use a regular bold style.


Version: unspecified
Severity: minor

Attached:

mixed_bugzilla.png (471×972 px, 27 KB)

Details

Reference
bz59749

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 2:24 AM
bzimport set Reference to bz59749.
bzimport added a subscriber: Unknown Object (MLST).

I guess I have to find some way to reproduce (font settings) because I've never seen this.

Probably only occurs with Arial as the default font (this is true on Windows).

This is actually an upstream bug in Bugzilla itself - it just never rears its head anywhere else because BZ is not usually displayed in Arial font.

There's no reason why we can't fix it locally, though.

Change 105921 had a related patch set uploaded by TTO:
Fix double-bolding of bug field labels with Arial font

https://gerrit.wikimedia.org/r/105921

Thanks for the patch!

(In reply to comment #0)

Our local custom Wikimedia skin

(In reply to comment #3)

This is actually an upstream bug in Bugzilla itself

These two lines feel slightly contradictive. Is this an issue that I should upstream to https://bugzilla.mozilla.org/ or not? Does it also happen if you use "Classic" or "Dust" CSS? Sorry, don't have a Windows machine around now...

The bug is arguably caused by some rather loopy and inconsistent HTML and CSS in the global Bugzilla files. But it is never exposed until the page is displayed using Arial (or another font with a "Black" variant).

Since our Wikimedia skin uses the browser's default sans-serif font, which is normally Arial on windows machines, the bug is "exposed" by our local skin. I didn't realise this when I wrote comment 0.

And yes, if you could upstream it, it would be great.

Probably best to test first on https://landfill.bugzilla.org/bugzilla-tip/ after creating an account there as we still run 4.2 currently.

I'm pretty sure this has been fixed upstream, however when we upgrade we will need to fix the modified version of edit.html.tmpl.

In the meantime, the options are either to use this ugly CSS hack, or else to muck around with edit.html.tmpl and potentially other template files (not yet in the modifications repo) to fix the messy HTML.

Change 105921 abandoned by TTO:
Fix double-bolding of bug field labels with Arial font

Reason:
No longer relevant with 4.4 upgrade, see bug report

https://gerrit.wikimedia.org/r/105921

After the upgrade, all is well, *except* the "Component" label, which is still in extra bold text, and is also missing its trailing colon.

Abandoning the patch as no longer relevant. I'll upload a new patch if I can find the cause of the issue.

Change 113095 had a related patch set uploaded by TTO:
Update custom Component label to match 4.4 styling

https://gerrit.wikimedia.org/r/113095

Change 113095 merged by Dzahn:
Update custom Component label to match 4.4 styling

https://gerrit.wikimedia.org/r/113095