Page MenuHomePhabricator
Create Task
Maniphest T61767

setting to specify location of NormalizationTest.txt
Closed, DeclinedPublic
Actions

Description

I noticed the test suite for Scribunto skip two tests because they can't find the file NormalizationTest.txt which comes from Unicode.

We can get the file installed on Jenkins server either:

  • by installing the unicode-data package which provide a bziped version of it, maybe use puppet to decompress it
  • add the uncompressed NormalizationTest.txt file to integration/jenkins.git so it would ends up being available under /srv/deployment/integration/slave-scripts/

In both cases, it would be helpful to have a $wg variable to let us override the current hardcoded DIR . "/NormalizationTest.txt"

Version: master
Severity: normal

Details

Reference
bz59767

Related Objects

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:25 AM
• bzimport added a project: Scribunto.
• bzimport set Reference to bz59767.
• bzimport added a subscriber: Unknown Object (MLST).
hashar created this task.Jan 7 2014, 2:36 PM
Anomie added a comment.Jan 7 2014, 2:53 PM

Note actually including this file raises the number of tests run for Scribunto from 1378 to around 38000.

Also, if I recall correctly, Scribunto (like MediaWiki) passes against 6.0.0, and not necessarily against the normalizations added in later versions of Unicode.

hashar added a comment.Feb 10 2014, 9:45 AM

Also, if I recall correctly, Scribunto (like MediaWiki) passes against 6.0.0,
and not necessarily against the normalizations added in later versions of
Unicode.

Ubuntu Precise ships Unicode data 6.0.0 for now. So it seems we can reuse it.

hashar added a comment.Jul 28 2014, 9:39 AM
  • Bug 68643 has been marked as a duplicate of this bug. ***
hashar merged a task: T70643: scribunto: phpunit tests skipped: Download the Unicode Normalization Test Suite.Nov 24 2016, 1:55 PM
hashar added subscribers: ori, yuvipanda.
• Phabricator_maintenance removed a subscriber: yuvipanda.Jun 7 2017, 7:01 PM
Anomie added a comment.Mar 12 2019, 2:12 PM
In T61767#616505, @Anomie wrote:

Note actually including this file raises the number of tests run for Scribunto from 1378 to around 38000.

FYI: I just had a need to run these tests again while looking into T217973. It took my T480 laptop 14.9 minutes to run UstringLibraryTest.php with http://unicode.org/Public/8.0.0/ucd/NormalizationTest.txt, versus 7.15 seconds without.

Your times may differ, of course, depending on how much CPU power you have available to the test runner.

hashar closed this task as Declined.Mar 25 2019, 11:48 AM

This is quite old. If I remember well, I had just seen the tests being skipped and indeed there is not much point in running them all on CI. Though maybe eventually that could be made a very specific job that asserts the tests pass fine against various ucd published files. But it is probably better to just handle it manually :)

Aklapper removed subscribers: Anomie, • wikibugs-l-list.Oct 16 2020, 5:29 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL