Maniphest T61771

Back button does funny things still
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	MarkTraceur
	Jan 7 2014, 3:43 PM

Tags

Referenced Files

None

Subscribers

• Fabrice_Florin

• wikibugs-l-list

Description

Further refactor/testing should be done on the back-button handler, because now when I visit https://www.mediawiki.org/wiki/Multimedia/About_Media_Viewer and click on an image that isn't the first, then use alt+left-arrow to go back, it redirects me (?) to the same image. I don't know why.

Reported by someone on Mac OS X and Chrome, with cmd+left-arrow instead, and instead it loaded the previous image for her. Browser testing may be in line here too.

Version: unspecified
Severity: normal

Details

Reference: bz59771

Event Timeline

• bzimport raised the priority of this task from to High.Nov 22 2014, 2:25 AM

• bzimport added a project: MediaViewer.

• bzimport set Reference to bz59771.

• bzimport added a subscriber: Unknown Object (MLST).

MarkTraceur created this task.Jan 7 2014, 3:43 PM

Maybe MMV's cursor key navigation and the browser's history navigation are both triggered and cancel each other out?

This is definitely due to the mmv's arrow keys management not ignoring keypresses when a modifier key is on.

https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/236

https://gerrit.wikimedia.org/r/115639

• Gilles added a project: Multimedia.Dec 4 2014, 9:35 AM

• Gilles raised the priority of this task from High to Unbreak Now!.Dec 4 2014, 10:11 AM

• Gilles moved this task from Untriaged to Done on the Multimedia board.

• Gilles lowered the priority of this task from Unbreak Now! to High.Dec 4 2014, 11:22 AM