Page MenuHomePhabricator

Cite: Improper state resetting when multiple <references /> tags are present
Closed, ResolvedPublic

Description

Both a-tags have identical hrefs, both li-tags have identical about attrs and ids whereas they shouldn't since the hrefs point to different references and ids should be unique on a page.

[subbu@earth lib] echo "X <ref>one</ref> <references />\n\nY <ref>two</ref> <references />" | node parse
<body data-parsoid='{"dsr":[0,65,0,0]}'>X <span about="#mwt3" class="reference" data-mw='{"name":"ref","body":{"html":"one"},"attrs":{}}' id="cite_ref-1-0" rel="dc:references" typeof="mw:Extension/ref" data-parsoid='{"src":"&lt;ref>one&lt;/ref>","dsr":[2,16,5,6]}'><a href="#cite_note-1">[1]</a></span> <ol class="references" typeof="mw:Extension/references" about="#mwt4" data-parsoid='{"src":"&lt;references />","dsr":[17,31,2,2]}' data-mw='{"name":"references","attrs":{}}'><li about="#cite_note-1" id="cite_note-1" data-parsoid="{}"><span rel="mw:referencedBy"><a href="#cite_ref-1-0">↑</a></span> one</li></ol>

Y <span about="#mwt7" class="reference" data-mw='{"name":"ref","body":{"html":"two"},"attrs":{}}' id="cite_ref-1-0" rel="dc:references" typeof="mw:Extension/ref" data-parsoid='{"src":"&lt;ref>two&lt;/ref>","dsr":[35,49,5,6]}'><a href="#cite_note-1">[1]</a></span> <ol class="references" typeof="mw:Extension/references" about="#mwt8" data-parsoid='{"src":"&lt;references />","dsr":[50,64,2,2]}' data-mw='{"name":"references","attrs":{}}'><li about="#cite_note-1" id="cite_note-1" data-parsoid="{}"><span rel="mw:referencedBy"><a href="#cite_ref-1-0">↑</a></span> two</li></ol>
</body>


Version: unspecified
Severity: normal

Details

Reference
bz59782

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 2:26 AM
bzimport added a project: Parsoid.
bzimport set Reference to bz59782.

Subbu: isn't this "References: 3. ref list should be cleared after processing references"?

Arlo: yes .. that is the test. It will need updating as well.

Change 106772 had a related patch set uploaded by Arlolra:
Properly bump reference anchors

https://gerrit.wikimedia.org/r/106772

Change 106772 merged by jenkins-bot:
Properly bump reference anchors

https://gerrit.wikimedia.org/r/106772