Page MenuHomePhabricator
Create Task
Maniphest T61791

LQT: PHP Fatal error: Call to a member function setFragment() on a non-object in ThreadPermalinkView.php on line 168
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

[07-Jan-2014 20:25:35] Fatal error: Call to a member function setFragment() on a non-object at /usr/local/apache/common-local/php-1.23wmf9/extensions/LiquidThreads/pages/ThreadPermalinkView.php on line 168
Server: mw1075
Method: GET
URL: http://www.mediawiki.org/wiki/Thread:Project:Support_desk/Enter_information_for_Leon_Turner_of_Life_in_Wikipedia_database./reply_(2)
Backtrace:
#0 /usr/local/apache/common-local/php-1.23wmf9/extensions/LiquidThreads/pages/ThreadPermalinkView.php(168): ThreadPermalinkView::getSubtitle()
#1 /usr/local/apache/common-local/php-1.23wmf9/extensions/LiquidThreads/pages/ThreadPermalinkView.php(231): ThreadPermalinkView->getSubtitle()
#2 /usr/local/apache/common-local/php-1.23wmf9/extensions/LiquidThreads/classes/Dispatch.php(100): ThreadPermalinkView->show()
#3 /usr/local/apache/common-local/php-1.23wmf9/extensions/LiquidThreads/classes/Dispatch.php(220): LqtDispatch::threadPermalinkMain(Object(OutputPage), Object(Article), Object(Title), Object(User), Object(WebRequest))
#4 [internal function]: LqtDispatch::tryPage(Object(OutputPage), Object(Article), Object(Title), Object(User), Object(WebRequest), Object(MediaWiki))
#5 /usr/local/apache/common-local/php-1.23wmf9/includes/Hooks.php(199): call_user_func_array('LqtDispatch::tr...', Array)
#6 /usr/local/apache/common-local/php-1.23wmf9/includes/GlobalFunctions.php(4032): Hooks::run('MediaWikiPerfor...', Array)
#7 /usr/local/apache/common-local/php-1.23wmf9/includes/Wiki.php(423): wfRunHooks('MediaWikiPerfor...', Array)
#8 /usr/local/apache/common-local/php-1.23wmf9/includes/Wiki.php(305): MediaWiki->performAction(Object(Article), Object(Title))
#9 /usr/local/apache/common-local/php-1.23wmf9/includes/Wiki.php(596): MediaWiki->performRequest()
#10 /usr/local/apache/common-local/php-1.23wmf9/includes/Wiki.php(460): MediaWiki->main()
#11 /usr/local/apache/common-local/php-1.23wmf9/index.php(49): MediaWiki->run()
#12 /usr/local/apache/common-local/w/index.php(3): require('/usr/local/apac...')
#13 {main}

From T56670 can be reproduced via https://www.mediawiki.org/wiki/Thread:Talk:MediaWiki_1.19/Broken_redirects_and_sidebar_display_after_upgrade_from_MW_1.12_to_MW_1.19/reply_(2)

Version: unspecified
Severity: normal
See Also:
T43056: LQT: Call to a member function getPrefixedText() on a non-object in ThreadPermalinkView.php on line 207
T56254: LQT: Call to a member function getPrefixedText() on a non-object in ThreadPermalinkView.php on line 83

Details

Reference
bz59791
SubjectRepoBranchLines +/-
Another speculative fix for when topmostThread title is not foundmediawiki/extensions/LiquidThreadsmaster+7 -6
Speculative to avoid setting subtitle when no title is foundmediawiki/extensions/LiquidThreadsmaster+8 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:27 AM
• bzimport added a project: MediaWiki-extensions-LiquidThreads.
• bzimport set Reference to bz59791.
• bzimport added a subscriber: Unknown Object (MLST).
Reedy created this task.Jan 7 2014, 8:33 PM
Reedy added a comment.Jan 7 2014, 8:35 PM
		if ( $this->thread->hasSuperthread() ) {
			$topmostTitle = $this->thread->topmostThread()->title();
			$topmostTitle->setFragment( $fragment );

			$linkText = wfMessage( 'lqt_discussion_link' )->parse();
			$permalink = Linker::link( $topmostTitle, $linkText );

			return wfMessage( 'lqt_fragment' )->rawParams( $permalink, $talkpage_link )->parse();
		} else {
			return wfMessage( 'lqt_from_talk' )->rawParams( $talkpage_link )->parse();
		}

Can and will return null:
$topmostTitle = $this->thread->topmostThread()->title();

Aklapper added a comment.Feb 10 2014, 11:58 AM
  • Bug 54670 has been marked as a duplicate of this bug. ***
Aklapper added a comment.Feb 10 2014, 12:00 PM

Both reported tickets and one reported today in #wikimedia-tech are a link ending with
/reply_(2)

• werdna unsubscribed.Dec 10 2014, 5:27 PM
• demon added a project: Wikimedia-production-error.Feb 18 2015, 8:00 PM
• demon set Security to None.
Jdforrester-WMF added a project: Collaboration-Team-Triage.Jun 3 2015, 10:05 PM
hashar renamed this task from PHP Fatal error: Call to a member function setFragment() on a non-object in ThreadPermalinkView.php on line 168 to LQT: PHP Fatal error: Call to a member function setFragment() on a non-object in ThreadPermalinkView.php on line 168.Jun 5 2015, 10:01 AM
hashar updated the task description. (Show Details)
hashar merged a task: T56670: Fatal error: Call to a member function setFragment() on a non-object in ThreadPermalinkView.php on line 168.
hashar added subscribers: siebrand, • werdna.
hashar lowered the priority of this task from Medium to Low.Jun 5 2015, 10:04 AM
hashar subscribed.

Barely happens in production. Seems to be triggered when accessing a thread that has been deleted.

hashar moved this task from Untriaged to Dec2019/1.35.wmf.10+ on the Wikimedia-production-error board.Jun 5 2015, 10:04 AM
• demon moved this task from Dec2019/1.35.wmf.10+ to Mar 2021 on the Wikimedia-production-error board.Jun 11 2015, 4:46 PM
Nemo_bis added a comment.Aug 27 2015, 11:07 AM

Another example:

Exception encountered, of type "BadMethodCallException"
[4e2c3a38] /w/i.php?oldid=3855518 BadMethodCallException from line 123 of /srv/mediawiki/tags/2015-08-26_14:44:03/extensions/LiquidThreads/pages/ThreadPermalinkView.php: Call to a member function setFragment() on a non-object (NULL)
Backtrace:
#0 /srv/mediawiki/tags/2015-08-26_14:44:03/extensions/LiquidThreads/pages/ThreadPermalinkView.php(186): ThreadPermalinkView->getSubtitle()
#1 /srv/mediawiki/tags/2015-08-26_14:44:03/extensions/LiquidThreads/classes/Dispatch.php(101): ThreadPermalinkView->show()
#2 /srv/mediawiki/tags/2015-08-26_14:44:03/extensions/LiquidThreads/classes/Dispatch.php(223): LqtDispatch::threadPermalinkMain(OutputPage, Article, Title, User, WebRequest)
#3 /srv/mediawiki/tags/2015-08-26_14:44:03/includes/Hooks.php(204): LqtDispatch::tryPage(OutputPage, Article, Title, User, WebRequest, MediaWiki)
#4 /srv/mediawiki/tags/2015-08-26_14:44:03/includes/MediaWiki.php(435): Hooks::run(string, array)
#5 /srv/mediawiki/tags/2015-08-26_14:44:03/includes/MediaWiki.php(255): MediaWiki->performAction(Article, Title)
#6 /srv/mediawiki/tags/2015-08-26_14:44:03/includes/MediaWiki.php(683): MediaWiki->performRequest()
#7 /srv/mediawiki/tags/2015-08-26_14:44:03/includes/MediaWiki.php(474): MediaWiki->main()
#8 /srv/mediawiki/tags/2015-08-21_05:37:22/index.php(41): MediaWiki->run()
#9 {main}

https://translatewiki.net/w/i.php?oldid=3855518 (not deleted)

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 27 2015, 11:07 AM
• Mattflaschen-WMF raised the priority of this task from Low to Medium.Aug 27 2015, 6:08 PM
• Mattflaschen-WMF subscribed.
Paladox subscribed.Dec 2 2015, 9:38 PM

I think this is fixed now.

hashar updated the task description. (Show Details)Dec 2 2015, 9:48 PM

It is not fixed. From T56670 can be reproduced via https://www.mediawiki.org/wiki/Thread:Talk:MediaWiki_1.19/Broken_redirects_and_sidebar_display_after_upgrade_from_MW_1.12_to_MW_1.19/reply_(2)

Paladox added a comment.Dec 2 2015, 9:56 PM

Could this be raised to high or unbreak now since it is broken at https://www.mediawiki.org/wiki/Thread:Talk:MediaWiki_1.19/Broken_redirects_and_sidebar_display_after_upgrade_from_MW_1.12_to_MW_1.19/reply_(2)

Reedy added a comment.Dec 3 2015, 12:12 AM
			$topmostTitle = $this->thread->topmostThread()->title();
			$topmostTitle->setFragment( $fragment );

So title() is returning null, which it is documented that it can do..

Aklapper added a comment.Dec 3 2015, 9:35 AM
In T61791#1846066, @Paladox wrote:

Could this be raised to high or unbreak now

Not without explaining why you think this bug has suddenly become more urgent (having a testcase does not make this suddenly more urgent to fix). Report status and priority fields summarize and reflect reality and do not cause it.

Jdforrester-WMF lowered the priority of this task from Medium to Lowest.Aug 4 2016, 11:33 PM
Jdforrester-WMF subscribed.

LiquidThreads has been replaced by StructuredDiscussions on all Wikimedia production wikis (except one, which will be done soon). It is no longer under active development or maintenance, so I'm re-classifying all open LQT tasks as "Lowest" priority.

Nemo_bis raised the priority of this task from Lowest to Medium.Aug 5 2016, 7:32 AM
Liuxinyu970226 mentioned this in T106687: Flow does not support varying language of parts of content based on user interface language (e.g. {{int:}}).Jan 22 2017, 3:20 PM
• demon merged a task: T149283: [BUG] liquidthreads fatal in wmf 1.28-wmf.23.Apr 20 2017, 7:18 PM
• demon added subscribers: Matanya, • demon, gerritbot, Ciencia_Al_Poder.
dr0ptp4kt subscribed.May 2 2018, 10:32 PM

Understood it's low priority. Just adding another URL to the heap: https://www.mediawiki.org/wiki/Thread:Project:Support_desk/Adding_custom_style_for_special_pages/reply_(2)

Saw this in a Search Console error.

• demon unsubscribed.May 2 2018, 11:13 PM
hashar unsubscribed.May 3 2018, 1:15 PM
Liuxinyu970226 updated the task description. (Show Details)May 20 2018, 6:59 AM
Krinkle moved this task from Mar 2021 to Dec2019/1.35.wmf.10+ on the Wikimedia-production-error board.Jul 31 2018, 11:48 PM
Krinkle subscribed.
In T61791#4176789, @dr0ptp4kt wrote:

Understood it's low priority. Just adding another URL to the heap: https://www.mediawiki.org/wiki/Thread:Project:Support_desk/Adding_custom_style_for_special_pages/reply_(2)

Thanks, this is still reproducible.

2018-07-31 23:24:47 [W2DvvwpAMFsAAENTQn4AAAAX] mw1256 mediawikiwiki 1.32.0-wmf.15 exception ERROR: /wiki/Thread:Project:Support_desk/Adding_custom_style_for_special_pages/reply_(2)

[Exception BadMethodCallException] (/srv/mediawiki/php-1.32.0-wmf.15/extensions/LiquidThreads/pages/ThreadPermalinkView.php:130) Call to a member function setFragment() on a non-object (null)
  #0 /srv/mediawiki/php-1.32.0-wmf.15/extensions/LiquidThreads/pages/ThreadPermalinkView.php(193): ThreadPermalinkView->getSubtitle()
  #1 /srv/mediawiki/php-1.32.0-wmf.15/extensions/LiquidThreads/classes/Dispatch.php(102): ThreadPermalinkView->show()
  #2 /srv/mediawiki/php-1.32.0-wmf.15/extensions/LiquidThreads/classes/Dispatch.php(224): LqtDispatch::threadPermalinkMain(OutputPage, Article, Title, User, WebRequest)
  #3 /srv/mediawiki/php-1.32.0-wmf.15/includes/Hooks.php(174): LqtDispatch::tryPage(OutputPage, Article, Title, User, WebRequest, MediaWiki)
  #4 /srv/mediawiki/php-1.32.0-wmf.15/includes/Hooks.php(202): Hooks::callHook(string, array, array, NULL)
  #5 /srv/mediawiki/php-1.32.0-wmf.15/includes/MediaWiki.php(472): Hooks::run(string, array)
  #6 /srv/mediawiki/php-1.32.0-wmf.15/includes/MediaWiki.php(294): MediaWiki->performAction(Article, Title)
  #7 /srv/mediawiki/php-1.32.0-wmf.15/includes/MediaWiki.php(867): MediaWiki->performRequest()
  #8 /srv/mediawiki/php-1.32.0-wmf.15/includes/MediaWiki.php(524): MediaWiki->main()
Liuxinyu970226 edited projects, added Growth-Team; removed Collaboration-Team-Triage.Sep 4 2018, 2:34 PM
Krinkle moved this task from Dec2019/1.35.wmf.10+ to Apr 2019 / 1.33.wmf.25+ on the Wikimedia-production-error board.Sep 12 2018, 10:33 PM
Krinkle moved this task from Apr 2019 / 1.33.wmf.25+ to Older on the Wikimedia-production-error board.Sep 19 2018, 12:59 AM
Krinkle mentioned this in Blog Post: Production Excellence #7: January 2019.Feb 13 2019, 3:53 AM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:12 PM
gerritbot added a comment.Aug 29 2019, 7:35 AM

Change 533153 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/LiquidThreads@master] Speculative to avoid setting subtitle when no title is found

https://gerrit.wikimedia.org/r/533153

kostajh edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.Aug 29 2019, 7:35 AM
gerritbot added a project: Patch-For-Review.Aug 29 2019, 7:35 AM
kostajh moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Aug 29 2019, 7:35 AM
gerritbot added a comment.Aug 29 2019, 11:36 AM

Change 533153 merged by jenkins-bot:
[mediawiki/extensions/LiquidThreads@master] Speculative to avoid setting subtitle when no title is found

https://gerrit.wikimedia.org/r/533153

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.21; 2019-09-03).Aug 29 2019, 12:00 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 29 2019, 12:10 PM
kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Sep 4 2019, 9:32 AM
gerritbot added a comment.Sep 4 2019, 9:42 AM

Change 534396 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/LiquidThreads@master] Another speculative fix for when topmostThread title is not found

https://gerrit.wikimedia.org/r/534396

gerritbot added a project: Patch-For-Review.Sep 4 2019, 9:42 AM
kostajh moved this task from QA to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Sep 4 2019, 9:43 AM
kostajh subscribed.

Still fails, see https://logstash.wikimedia.org/app/kibana#/doc/logstash-*/logstash-2019.09.04/mediawiki?id=AWz7npihaTyU0YVHVcfa&_g=h@44136fa

#0 /srv/mediawiki/php-1.34.0-wmf.21/extensions/LiquidThreads/pages/ThreadPermalinkView.php(193): ThreadPermalinkView->getSubtitle()
#1 /srv/mediawiki/php-1.34.0-wmf.21/extensions/LiquidThreads/classes/Dispatch.php(102): ThreadPermalinkView->show()
#2 /srv/mediawiki/php-1.34.0-wmf.21/extensions/LiquidThreads/classes/Dispatch.php(224): LqtDispatch::threadPermalinkMain(OutputPage, Article, Title, User, WebRequest)
#3 /srv/mediawiki/php-1.34.0-wmf.21/includes/Hooks.php(174): LqtDispatch::tryPage(OutputPage, Article, Title, User, WebRequest, MediaWiki)
#4 /srv/mediawiki/php-1.34.0-wmf.21/includes/Hooks.php(202): Hooks::callHook(string, array, array, NULL)
#5 /srv/mediawiki/php-1.34.0-wmf.21/includes/MediaWiki.php(479): Hooks::run(string, array)
#6 /srv/mediawiki/php-1.34.0-wmf.21/includes/MediaWiki.php(302): MediaWiki->performAction(Article, Title)
#7 /srv/mediawiki/php-1.34.0-wmf.21/includes/MediaWiki.php(892): MediaWiki->performRequest()
#8 /srv/mediawiki/php-1.34.0-wmf.21/includes/MediaWiki.php(523): MediaWiki->main()
#9 /srv/mediawiki/php-1.34.0-wmf.21/index.php(42): MediaWiki->run()
#10 /srv/mediawiki/w/index.php(3): include(string)
#11 {main}
gerritbot added a comment.Sep 5 2019, 8:43 PM

Change 534396 merged by jenkins-bot:
[mediawiki/extensions/LiquidThreads@master] Another speculative fix for when topmostThread title is not found

https://gerrit.wikimedia.org/r/534396

ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.22; 2019-09-10); removed MW-1.34-notes (1.34.0-wmf.21; 2019-09-03).Sep 5 2019, 9:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 5 2019, 9:11 PM
Krinkle closed this task as Resolved.Sep 5 2019, 10:39 PM
Krinkle assigned this task to kostajh.

Presumed fixed.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL