Page MenuHomePhabricator

Encode/decode filenames for the hash fragment
Closed, ResolvedPublic

Description

When we don't, people copying/pasting from their URL bar will have funky strings that MMV doesn't understand. From Fabrice:

https://www.mediawiki.org/wiki/Lightbox_demo#mediaviewer/File:How%20to%20Make%20Wikipedia%20Better%20-%20Wikimania%202013%20-%2011.jpg/3

So, we'll just urlencode it first. Easy enough.


Version: unspecified
Severity: normal

Details

Reference
bz59795

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:27 AM
bzimport added a project: MediaViewer.
bzimport set Reference to bz59795.
bzimport added a subscriber: Unknown Object (MLST).

Maybe use anchorencode? Looks nicer, and that way people can use [[foo#bar]] notation to link to the lightbox.

Is this still relevant now that the %20 bug has been fixed? If so, please move it to mingle.

I created #206 for this (partially) a while ago:
https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/206

I think the bug can be closed, the lack of encoding does not cause any error now.

Gilles raised the priority of this task from Medium to Unbreak Now!.Dec 4 2014, 10:24 AM
Gilles moved this task from Untriaged to Done on the Multimedia board.
Gilles lowered the priority of this task from Unbreak Now! to Medium.Dec 4 2014, 11:20 AM