Page MenuHomePhabricator
Create Task
Maniphest T61831

Tasks with abandoned changes shouldn't have Patch-for-Review
Closed, DuplicatePublic
Actions

Description

When a Gerrit change for a bug is abandoned, if the bug is PATCH_TO_REVIEW, Gerrit Notification Bot should change it back to its previous status when it posts the abandonment message.

Version: wmf-deployment
Severity: enhancement
See Also:
T58689: Bugzilla issue status should remain unchanged when patch set is abandoned
T95309: make gerritbot remove the "patch-for-review" tag once a patch is merged (or abandoned)
T104413: remove automatic addition of "patch for review" if it can't also be automatically removed on merge

Details

Reference
bz59831

Related Objects

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 2:30 AM
• bzimport added a project: Gerrit.
• bzimport set Reference to bz59831.
• bzimport added a subscriber: Unknown Object (MLST).
Jackmcbarn created this task.Jan 8 2014, 8:06 PM
Aklapper added a comment.Jan 9 2014, 2:06 PM

Just adding a comment that I don't have a strong opinion on this.

Jack's point is valid (especially when it comes to the wording TO_REVIEW), but patches might be abandoned also for non-technical reasons (e.g. submitter not interested anymore, or bug 39139 comment 8), and might still make a bug "closer" to getting fixed when somebody picks up the (abandoned) code again.

• bzimport added a comment.Sep 25 2014, 6:01 PM

wp.makyen wrote:

I agree that the status of bugs for which the only Gerrit change(s) are at a status of Abandoned should not show a status of PATCH_TO_REVIEW. It is deceptive and counter to actually getting the bug resolved. For example, when looking for a bug to start work on would you ever choose to include bugs with the status PATCH_TO_REVIEW in your search results?

The reason for the abandonment is not relevant. The effective status is that the bug needs the attention of a developer to begin work on a solution. If it happens that there is code which might be adapted or used as a starting point that is something that the developer can determine by reading the bug.

The point is to return such bugs to the point where they are appropriately placed within the Bug management/Bug report life cycle. The way to do that is to remove the effect that having the abandoned Gerrit change is having on the status of the bug.

Aklapper added a comment.Sep 25 2014, 8:24 PM

I would not spend too much time thinking about this, because in a few months we will neither have Bugzilla nor Gerrit anymore if all goes well. :)
See https://www.mediawiki.org/wiki/Phabricator

• demon unsubscribed.Dec 8 2014, 6:33 PM
Aklapper renamed this task from Bugs with abandoned changes shouldn't be PATCH_TO_REVIEW to Tasks with abandoned changes shouldn't have Patch-for-Review.Feb 9 2015, 8:24 PM
Aklapper lowered the priority of this task from Low to Lowest.
Aklapper set Security to None.
Aklapper subscribed.
Aklapper mentioned this in T95309: make gerritbot remove the "patch-for-review" tag once a patch is merged (or abandoned).Jul 1 2015, 1:18 PM
Aklapper updated the task description. (Show Details)
Aklapper mentioned this in T104413: remove automatic addition of "patch for review" if it can't also be automatically removed on merge.
Aklapper mentioned this in T128491: OCG needs to migrate away from rdb1002 and get its own Redis instance.Mar 3 2016, 9:45 AM
Ricordisamoa subscribed.Mar 4 2016, 11:02 AM
Paladox closed this task as a duplicate of T95309: make gerritbot remove the "patch-for-review" tag once a patch is merged (or abandoned).Aug 7 2016, 1:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL