Page MenuHomePhabricator
Create Task
Maniphest T61853

Should say "Thanks" instead of "OK" in confirmation dialog
Closed, InvalidPublic
Actions

Description

This is cosmetic, but OK/Cancel dialog boxes are really Not Cool (tm), because there is some extra cognitive load in figuring out what "OK" does. All the major platform's user interface guidelines recommend labeling buttons with active verbs relevant to the action - in this case "Thanks".

[An action this harmless should not even have a confirmation dialog, just undo instead. But I realize having an undo option is probably a lot of work, so not going to file that request now.]

Version: unspecified
Severity: trivial

Details

Reference
bz59853

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:31 AM
• bzimport added projects: Thanks, good first task.
• bzimport set Reference to bz59853.
• bzimport added a subscriber: Unknown Object (MLST).
• LuisV_WMF created this task.Jan 9 2014, 2:13 AM
Legoktm added a comment.Jan 9 2014, 2:21 AM

So something like "Send thanks" / "Cancel"?

• LuisV_WMF added a comment.Jan 9 2014, 2:24 AM

Could be simply "Thank" / "Cancel", since thank is an action verb.

Anjanasasindran123 added a comment.Jan 12 2014, 4:04 PM

I would like to work on this bug.Can someone please assign this to me.

matmarex added a comment.Jan 12 2014, 4:05 PM

It is okay to work on unassigned bugs without having them assigned to you.
(That's in fact what we usually do.)

Anjanasasindran123 added a comment.Jan 14 2014, 5:20 AM

Yea ! I have started working on this bug by cloning the extension and stuffs to my localhost.But I'm not able to figure out the exact position of this bug.Can someone please help me by providing a link regarding this or a screenshot may be helpful.

01tonythomas added a comment.Jan 14 2014, 5:37 AM

someone please help me by providing a link regarding this or a screenshot may
be helpful.

Firstly, you need to install the Thanks extensions as given here
http://www.mediawiki.org/wiki/Extension:Thanks
Then Check the Usage section to find out How to give 'Thanks' to a user. You will find out the confirmation box then.

gerritbot added a comment.Jan 14 2014, 10:50 AM

Change 107350 had a related patch set uploaded by 01tonythomas:
Changed "OK" to "Thank" in confirmation dialog box

https://gerrit.wikimedia.org/r/107350

Anjanasasindran123 added a comment.Jan 14 2014, 1:27 PM

I have resubmitted the patch for review.Does this patch looks ok?

Anjanasasindran123 added a comment.Jan 15 2014, 3:32 PM

I submitted my patch again.Does this looks ok?

gerritbot added a comment.Sep 19 2014, 1:15 AM

Change 107350 abandoned by Legoktm:
Changed "OK" to "Thank" in confirmation dialog box

Reason:
No progress since January, feel free to restore this patch by pressing "restore".

https://gerrit.wikimedia.org/r/107350

• Jaredzimmerman-WMF added a comment.Oct 2 2014, 9:04 PM

The confirmation dialog is no longer in use, now an in-line action is used instead to be mobile friendly. This should all still be replaced with https://bugzilla.wikimedia.org/show_bug.cgi?id=69636

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL