Page MenuHomePhabricator

replies and posts can fail with "no root post"
Closed, ResolvedPublic

Description

After re-enabling edits, Maryana's new topic succeded, but replies and new topics after that on the same page failed with: '050de353cea1034818d4782bcb077299 has no root post. Probably is a root post.'

2014-01-09 21:07:38 mw1127 mediawikiwiki: [3998d2ae] /w/api.php Exception from line 232 of /usr/local/apache/common-local/php-1.23wmf10/extensions/Flow/includes/Repository/TreeRepository.php: 050de353cea1034818d4782bcb077299 has no root post. Probably is a root post.
#0 /usr/local/apache/common-local/php-1.23wmf10/extensions/Flow/includes/Data/RevisionStorage.php(524): Flow\Repository\TreeRepository->findRoot(Object(Flow\Model\UUID))
#1 /usr/local/apache/common-local/php-1.23wmf10/extensions/Flow/includes/Data/ObjectManager.php(493): Flow\Data\TopicHistoryIndex->onAfterInsert(Object(Flow\Model\PostRevision), Array)
#2 /usr/local/apache/common-local/php-1.23wmf10/extensions/Flow/includes/Data/ObjectManager.php(470): Flow\Data\ObjectManager->insert(Object(Flow\Model\PostRevision))
#3 /usr/local/apache/common-local/php-1.23wmf10/extensions/Flow/includes/Data/ObjectManager.php(167): Flow\Data\ObjectManager->put(Object(Flow\Model\PostRevision))
#4 /usr/local/apache/common-local/php-1.23wmf10/extensions/Flow/includes/Block/Topic.php(345): Flow\Data\ManagerGroup->put(Object(Flow\Model\PostRevision))
#5 /usr/local/apache/common-local/php-1.23wmf10/extensions/Flow/includes/WorkflowLoader.php(206): Flow\Block\TopicBlock->commit()
#6 /usr/local/apache/common-local/php-1.23wmf10/extensions/Flow/includes/api/ApiFlow.php(59): Flow\WorkflowLoader->commit(Object(Flow\Model\Workflow), Array)
#7 /usr/local/apache/common-local/php-1.23wmf10/includes/api/ApiMain.php(886): ApiFlow->execute()
#8 /usr/local/apache/common-local/php-1.23wmf10/includes/api/ApiMain.php(387): ApiMain->executeAction()
#9 /usr/local/apache/common-local/php-1.23wmf10/includes/api/ApiMain.php(358): ApiMain->executeActionWithErrorHandling()
#10 /usr/local/apache/common-local/php-1.23wmf10/api.php(76): ApiMain->execute()
#11 /usr/local/apache/common-local/w/api.php(3): require('/usr/local/apac...')

also similar log error but different UUID

2014-01-09 21:08:30 mw1199 mediawikiwiki: [d4faf8a0] /w/api.php Exception from line 232 of /usr/local/apache/common-local/php-1.23wmf10/extensions/Flow/includes/Repository/TreeRepository.php: 050de356f59823bf2b5f90b11c2788f0 has no root post. Probably is a root post.
#0 /usr/local/apache/common-local/php-1.23wmf10/extensions/Flow/includes/Data/RevisionStorage.php(524): Flow\Repository\TreeRepository->findRoot(Object(Flow\Model\UUID))
#1 /usr/local/apache/common-local/php-1.23wmf10/extensions/Flow/includes/Data/ObjectManager.php(493): Flow\Data\TopicHistoryIndex->onAfterInsert(Object(Flow\Model\PostRevision), Array)
#2 /usr/local/apache/common-local/php-1.23wmf10/extensions/Flow/includes/Data/ObjectManager.php(470): Flow\Data\ObjectManager->insert(Object(Flow\Model\PostRevision))
#3 /usr/local/apache/common-local/php-1.23wmf10/extensions/Flow/includes/Data/ObjectManager.php(167): Flow\Data\ObjectManager->put(Object(Flow\Model\PostRevision))
#4 /usr/local/apache/common-local/php-1.23wmf10/extensions/Flow/includes/Block/Topic.php(345): Flow\Data\ManagerGroup->put(Object(Flow\Model\PostRevision))
#5 /usr/local/apache/common-local/php-1.23wmf10/extensions/Flow/includes/WorkflowLoader.php(206): Flow\Block\TopicBlock->commit()
#6 /usr/local/apache/common-local/php-1.23wmf10/extensions/Flow/includes/api/ApiFlow.php(59): Flow\WorkflowLoader->commit(Object(Flow\Model\Workflow), Array)
#7 /usr/local/apache/common-local/php-1.23wmf10/includes/api/ApiMain.php(886): ApiFlow->execute()
#8 /usr/local/apache/common-local/php-1.23wmf10/includes/api/ApiMain.php(387): ApiMain->executeAction()
#9 /usr/local/apache/common-local/php-1.23wmf10/includes/api/ApiMain.php(358): ApiMain->executeActionWithErrorHandling()
#10 /usr/local/apache/common-local/php-1.23wmf10/api.php(76): ApiMain->execute()
#11 /usr/local/apache/common-local/w/api.php(3): require('/usr/local/apac...')
#12 {main}


Version: master
Severity: critical
URL: https://www.mediawiki.org/wiki/Talk:Sandbox

Details

Reference
bz59884

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:34 AM
bzimport set Reference to bz59884.
bzimport added a subscriber: Unknown Object (MLST).

bingle-admin wrote:

The WMF core features team tracks this bug on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/flow/cards/706, but people from the community are welcome to contribute here and in Gerrit.

Change 106649 had a related patch set uploaded by Spage:
Update Flow to master (bug 59884)

https://gerrit.wikimedia.org/r/106649

Change 106649 merged by jenkins-bot:
Update Flow to master (bug 59884)

https://gerrit.wikimedia.org/r/106649

Fixed.

This also meant viewing a board with a failed post could fail with

Missing Posts: {"14":"050de380f7b8f1dc09e4842b2b77e6f9"}

that could still happen for other reasons, we should display a "Dead post" icon and show the other 9 topics.

(In reply to comment #4)

Fixed.

This also meant viewing a board with a failed post could fail with

Missing Posts: {"14":"050de380f7b8f1dc09e4842b2b77e6f9"}

This continues to happen, we've been cleaning it up by deleting garbled cache entries for unsuccessful posts made while this bug was in effect.

we should display a "Dead post" icon and show the other 9 topics.

I filed that as bug 59939.